> >> If yes, but it's healed later in the series, the temporary
> >> breakage still needs to be spelled out in the commit message.
> >
> > No, it's not healed, which is why it's mentioned in the commit
> > message that future work is needed.
>
> I really hate "reward" submissions of tons of useful
Paolo Bonzini writes:
> Il 17/10/2012 17:40, Markus Armbruster ha scritto:
>>> > if (s->current_addr) {
>>> > while (s->current_addr->ai_next != NULL && s->fd < 0) {
>>> > s->current_addr = s->current_addr->ai_next;
>>> > -s->fd = inet_connect_addr(s->curren
Il 17/10/2012 17:40, Markus Armbruster ha scritto:
>> > if (s->current_addr) {
>> > while (s->current_addr->ai_next != NULL && s->fd < 0) {
>> > s->current_addr = s->current_addr->ai_next;
>> > -s->fd = inet_connect_addr(s->current_addr, &in_progress, s);
>> >
Paolo Bonzini writes:
> perror and fprintf can be removed because all clients can now consume
> Errors properly. However, we need to change the non-blocking connect
> handlers to take an Error, in order to improve error handling for
> migration with the TCP protocol.
The second sentence is abou
On Wed, 10 Oct 2012 16:02:56 +0200
Paolo Bonzini wrote:
> perror and fprintf can be removed because all clients can now consume
> Errors properly. However, we need to change the non-blocking connect
> handlers to take an Error, in order to improve error handling for
> migration with the TCP prot
perror and fprintf can be removed because all clients can now consume
Errors properly. However, we need to change the non-blocking connect
handlers to take an Error, in order to improve error handling for
migration with the TCP protocol.
Reviewed-by: Paolo Bonzini
Signed-off-by: Paolo Bonzini
-
