Re: [Qemu-devel] [PATCH 2/2] linux-user: Fix TARGET_MTIOCTOP/MTIOCGET/MTIOCPOS values

2017-10-16 Thread Peter Maydell
On 16 October 2017 at 14:09, Laurent Vivier wrote: > For this part, yes, but I think for the other comment, STRUCT(mtget, > ...) needs to be updated. Looking more closely I don't think it is as simple as just adjusting the STRUCT() definition. For a basic type that can be

Re: [Qemu-devel] [PATCH 2/2] linux-user: Fix TARGET_MTIOCTOP/MTIOCGET/MTIOCPOS values

2017-10-16 Thread Laurent Vivier
Le 16/10/2017 à 15:26, Peter Maydell a écrit : > On 16 October 2017 at 14:09, Laurent Vivier wrote: >> For this part, yes, but I think for the other comment, STRUCT(mtget, >> ...) needs to be updated. > > Looking more closely I don't think it is as simple as just > adjusting

Re: [Qemu-devel] [PATCH 2/2] linux-user: Fix TARGET_MTIOCTOP/MTIOCGET/MTIOCPOS values

2017-10-16 Thread Laurent Vivier
Le 16/10/2017 à 15:06, Riku Voipio a écrit : > On Thu, Oct 12, 2017 at 07:08:55PM +0200, Laurent Vivier wrote: >> Le 12/10/2017 à 18:53, Peter Maydell a écrit : >>> On 12 October 2017 at 17:49, Laurent Vivier wrote: Le 12/10/2017 à 17:30, Peter Maydell a écrit : > +#if

Re: [Qemu-devel] [PATCH 2/2] linux-user: Fix TARGET_MTIOCTOP/MTIOCGET/MTIOCPOS values

2017-10-16 Thread Riku Voipio
On Thu, Oct 12, 2017 at 07:08:55PM +0200, Laurent Vivier wrote: > Le 12/10/2017 à 18:53, Peter Maydell a écrit : > > On 12 October 2017 at 17:49, Laurent Vivier wrote: > >> Le 12/10/2017 à 17:30, Peter Maydell a écrit : > >>> +#if defined(TARGET_SPARC) || defined(TARGET_MIPS) >

Re: [Qemu-devel] [PATCH 2/2] linux-user: Fix TARGET_MTIOCTOP/MTIOCGET/MTIOCPOS values

2017-10-12 Thread Laurent Vivier
Le 12/10/2017 à 18:53, Peter Maydell a écrit : > On 12 October 2017 at 17:49, Laurent Vivier wrote: >> Le 12/10/2017 à 17:30, Peter Maydell a écrit : >>> +#if defined(TARGET_SPARC) || defined(TARGET_MIPS) >>> +typedef abi_long target_kernel_daddr_t; >>> +#else >>> +typedef

Re: [Qemu-devel] [PATCH 2/2] linux-user: Fix TARGET_MTIOCTOP/MTIOCGET/MTIOCPOS values

2017-10-12 Thread Peter Maydell
On 12 October 2017 at 17:49, Laurent Vivier wrote: > Le 12/10/2017 à 17:30, Peter Maydell a écrit : >> +#if defined(TARGET_SPARC) || defined(TARGET_MIPS) >> +typedef abi_long target_kernel_daddr_t; >> +#else >> +typedef abi_int target_kernel_daddr_t; >> +#endif > > Perhaps you

Re: [Qemu-devel] [PATCH 2/2] linux-user: Fix TARGET_MTIOCTOP/MTIOCGET/MTIOCPOS values

2017-10-12 Thread Laurent Vivier
Le 12/10/2017 à 17:30, Peter Maydell a écrit : > The TARGET_MTIOCTOP/TARGET_MTIOCGET/TARGET_MTIOCPOS values > were being defined in terms of host struct types, but > these structures are such that their size might differ > on different hosts. Switch to using a target struct > definition instead. >

[Qemu-devel] [PATCH 2/2] linux-user: Fix TARGET_MTIOCTOP/MTIOCGET/MTIOCPOS values

2017-10-12 Thread Peter Maydell
The TARGET_MTIOCTOP/TARGET_MTIOCGET/TARGET_MTIOCPOS values were being defined in terms of host struct types, but these structures are such that their size might differ on different hosts. Switch to using a target struct definition instead. Signed-off-by: Peter Maydell