Headers usually start with a one-line summary, QEMU simulated block
driver maybe?
+ * Copyright (c) 2010-2011 IBM
+ *
+ * Authors:
+ * Chunqiang Tang ct...@us.ibm.com
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2.
+ * See the COPYING file in the
Read CODING_STYLE and go through your code.
Went through CODING_STYLE. The white space issue in FVD was already been
fixed previously. FVD’s variable and type names are fine, and line width
is fine. The only remaining issue in FVD is '}' before 'else', which will
be fixed. CODING_STYLE does
Am 21.01.2011 um 23:19 schrieb Chunqiang Tang:
diff --git a/block/blksim.c b/block/blksim.c
new file mode 100644
index 000..a92ba11
--- /dev/null
+++ b/block/blksim.c
Some formal comments, since you're introducing a new file:
@@ -0,0 +1,752 @@
+/*
Headers usually start with a one-line
This patch is part of the Fast Virtual Disk (FVD) proposal. See the related
discussions at
http://lists.gnu.org/archive/html/qemu-devel/2011-01/msg00426.html.
This patch adds the 'blksim' block device driver, which is a tool to
facilitate testing and debugging. blksim operates on a RAW image, but
On 01/21/2011 04:19 PM, Chunqiang Tang wrote:
This patch is part of the Fast Virtual Disk (FVD) proposal. See the related
discussions at
http://lists.gnu.org/archive/html/qemu-devel/2011-01/msg00426.html.
This patch adds the 'blksim' block device driver, which is a tool to
facilitate testing
Coding style.
In general, I like the idea of the simulator but the coding style is off
quite a bit.
Please be specific and I would be happy to take suggestions. The header
issue should be easy to fix.
