On 2018-08-23 00:50, John Snow wrote:
>
>
> On 08/22/2018 06:59 AM, Max Reitz wrote:
>> On 2018-08-21 02:10, John Snow wrote:
>>>
>>>
>>> On 08/17/2018 03:04 PM, John Snow wrote:
+error_setg_errno(>err, -job->ret, "job failed");
>>>
>>> Kevin specifically asked for me to change
On 08/22/2018 06:59 AM, Max Reitz wrote:
> On 2018-08-21 02:10, John Snow wrote:
>>
>>
>> On 08/17/2018 03:04 PM, John Snow wrote:
>>> +error_setg_errno(>err, -job->ret, "job failed");
>>
>> Kevin specifically asked for me to change this, and I lost it in the
>> shuffle. I'll send a
On 2018-08-17 21:04, John Snow wrote:
> Jobs presently use both an Error object in the case of the create job,
> and char strings in the case of generic errors elsewhere.
>
> Unify the two paths as just j->err, and remove the extra argument from
> job_completed. The integer error code for
On 2018-08-17 21:04, John Snow wrote:
> Jobs presently use both an Error object in the case of the create job,
> and char strings in the case of generic errors elsewhere.
>
> Unify the two paths as just j->err, and remove the extra argument from
> job_completed. The integer error code for
On 2018-08-21 02:10, John Snow wrote:
>
>
> On 08/17/2018 03:04 PM, John Snow wrote:
>> +error_setg_errno(>err, -job->ret, "job failed");
>
> Kevin specifically asked for me to change this, and I lost it in the
> shuffle. I'll send a v3 now, since there are enough nits to warrant
On 08/17/2018 03:04 PM, John Snow wrote:
> +error_setg_errno(>err, -job->ret, "job failed");
Kevin specifically asked for me to change this, and I lost it in the
shuffle. I'll send a v3 now, since there are enough nits to warrant it,
and I think I want to adjust a few things to set
On 08/17/2018 02:04 PM, John Snow wrote:
Jobs presently use both an Error object in the case of the create job,
and char strings in the case of generic errors elsewhere.
Unify the two paths as just j->err, and remove the extra argument from
job_completed. The integer error code for
Jobs presently use both an Error object in the case of the create job,
and char strings in the case of generic errors elsewhere.
Unify the two paths as just j->err, and remove the extra argument from
job_completed. The integer error code for job_completed is kept for now
for use by pre-emptive
