Re: [Qemu-devel] [PATCH 2/7] trace: Add event "guest_inst_before"

2017-09-14 Thread Lluís Vilanova
Richard Henderson writes: > On 09/10/2017 09:19 AM, Lluís Vilanova wrote: >> while (true) { >> +target_ulong pc_insn = db->pc_next; > Why not just "pc"? >> + db-> num_insns++; ops-> insn_start(db, cpu); >> tcg_debug_assert(db->is_jmp == DISAS_NEXT); /* no early exit */ >> @@ -96,6 +98,7

Re: [Qemu-devel] [PATCH 2/7] trace: Add event "guest_inst_before"

2017-09-13 Thread Richard Henderson
On 09/10/2017 09:19 AM, Lluís Vilanova wrote: > while (true) { > +target_ulong pc_insn = db->pc_next; Why not just "pc"? > + > db->num_insns++; > ops->insn_start(db, cpu); > tcg_debug_assert(db->is_jmp == DISAS_NEXT); /* no early exit */ > @@ -96,6 +98,7 @

[Qemu-devel] [PATCH 2/7] trace: Add event "guest_inst_before"

2017-09-10 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- accel/tcg/translator.c |3 +++ trace-events |8 2 files changed, 11 insertions(+) diff --git a/accel/tcg/translator.c b/accel/tcg/translator.c index 91b3b0da32..287d27b4f7 100644 --- a/accel/tcg/translator.c +++ b/accel/tcg/translator.