Re: [Qemu-devel] [PATCH 2/8] sparc64: fix missing address masking

2010-06-02 Thread Igor Kovalenko
On Wed, Jun 2, 2010 at 5:47 PM, Richard Henderson wrote: > On 06/01/2010 09:29 PM, Igor Kovalenko wrote: >> On Wed, Jun 2, 2010 at 12:44 AM, Richard Henderson wrote: >>> On 06/01/2010 01:12 PM, Igor V. Kovalenko wrote: +    if ((env->pstate & PS_AM) && is_translating_asi(asi)) { +      

Re: [Qemu-devel] [PATCH 2/8] sparc64: fix missing address masking

2010-06-02 Thread Igor Kovalenko
On Wed, Jun 2, 2010 at 8:46 PM, Andreas Färber wrote: > Am 02.06.2010 um 18:10 schrieb Blue Swirl: > >> On Wed, Jun 2, 2010 at 1:47 PM, Richard Henderson wrote: >>> >>> On 06/01/2010 09:29 PM, Igor Kovalenko wrote: On Wed, Jun 2, 2010 at 12:44 AM, Richard Henderson wrote: > >>

Re: [Qemu-devel] [PATCH 2/8] sparc64: fix missing address masking

2010-06-02 Thread Andreas Färber
Am 02.06.2010 um 18:10 schrieb Blue Swirl: On Wed, Jun 2, 2010 at 1:47 PM, Richard Henderson wrote: On 06/01/2010 09:29 PM, Igor Kovalenko wrote: On Wed, Jun 2, 2010 at 12:44 AM, Richard Henderson wrote: On 06/01/2010 01:12 PM, Igor V. Kovalenko wrote: +if ((env->pstate & PS_AM) && i

Re: [Qemu-devel] [PATCH 2/8] sparc64: fix missing address masking

2010-06-02 Thread Blue Swirl
On Wed, Jun 2, 2010 at 1:47 PM, Richard Henderson wrote: > On 06/01/2010 09:29 PM, Igor Kovalenko wrote: >> On Wed, Jun 2, 2010 at 12:44 AM, Richard Henderson wrote: >>> On 06/01/2010 01:12 PM, Igor V. Kovalenko wrote: +    if ((env->pstate & PS_AM) && is_translating_asi(asi)) { +      

Re: [Qemu-devel] [PATCH 2/8] sparc64: fix missing address masking

2010-06-02 Thread Richard Henderson
On 06/01/2010 09:29 PM, Igor Kovalenko wrote: > On Wed, Jun 2, 2010 at 12:44 AM, Richard Henderson wrote: >> On 06/01/2010 01:12 PM, Igor V. Kovalenko wrote: >>> +if ((env->pstate & PS_AM) && is_translating_asi(asi)) { >>> +addr &= 0xULL; >>> +} >> >> I suggest that these b

Re: [Qemu-devel] [PATCH 2/8] sparc64: fix missing address masking

2010-06-01 Thread Igor Kovalenko
On Wed, Jun 2, 2010 at 12:44 AM, Richard Henderson wrote: > On 06/01/2010 01:12 PM, Igor V. Kovalenko wrote: >> +    if ((env->pstate & PS_AM) && is_translating_asi(asi)) { >> +        addr &= 0xULL; >> +    } > > I suggest that these be written instead as > >  if (is_translating_asi(asi))

Re: [Qemu-devel] [PATCH 2/8] sparc64: fix missing address masking

2010-06-01 Thread Richard Henderson
On 06/01/2010 01:12 PM, Igor V. Kovalenko wrote: > +if ((env->pstate & PS_AM) && is_translating_asi(asi)) { > +addr &= 0xULL; > +} I suggest that these be written instead as if (is_translating_asi(asi)) { addr = address_mask(addr); } That should allow you to remov

[Qemu-devel] [PATCH 2/8] sparc64: fix missing address masking

2010-06-01 Thread Igor V. Kovalenko
From: Igor V. Kovalenko - address masking for ldqf and stqf insns - address masking for lddf and stdf insns - address masking for translating ASI (Ultrasparc IIi) Signed-off-by: Igor V. Kovalenko --- target-sparc/op_helper.c | 47 ++ target-sparc/t