Re: [Qemu-devel] [PATCH 21/26] kvmclock: use realize for kvmclock

2013-07-01 Thread Andreas Färber
Am 01.07.2013 11:31, schrieb Hu Tao: > On Sun, Jun 30, 2013 at 04:36:13PM +0200, Andreas Färber wrote: >> Am 25.06.2013 19:45, schrieb Eduardo Habkost: >>> On Tue, Jun 25, 2013 at 10:20:08AM +0800, Hu Tao wrote: >>> [...] > Is TYPE_SYS_BUS_DEVICE guaranteed to never override ->realize() itself?

Re: [Qemu-devel] [PATCH 21/26] kvmclock: use realize for kvmclock

2013-07-01 Thread Hu Tao
On Sun, Jun 30, 2013 at 04:36:13PM +0200, Andreas Färber wrote: > Am 25.06.2013 19:45, schrieb Eduardo Habkost: > > On Tue, Jun 25, 2013 at 10:20:08AM +0800, Hu Tao wrote: > > [...] > >>> Is TYPE_SYS_BUS_DEVICE guaranteed to never override ->realize() itself? > >>> > >>> From DeviceClass documentat

Re: [Qemu-devel] [PATCH 21/26] kvmclock: use realize for kvmclock

2013-06-30 Thread Andreas Färber
Am 25.06.2013 19:45, schrieb Eduardo Habkost: > On Tue, Jun 25, 2013 at 10:20:08AM +0800, Hu Tao wrote: > [...] >>> Is TYPE_SYS_BUS_DEVICE guaranteed to never override ->realize() itself? >>> >>> From DeviceClass documentation: >>> >>> * If a type derived directly from TYPE_DEVICE implements @real

Re: [Qemu-devel] [PATCH 21/26] kvmclock: use realize for kvmclock

2013-06-25 Thread Eduardo Habkost
On Tue, Jun 25, 2013 at 10:20:08AM +0800, Hu Tao wrote: [...] > > Is TYPE_SYS_BUS_DEVICE guaranteed to never override ->realize() itself? > > > > From DeviceClass documentation: > > > > * If a type derived directly from TYPE_DEVICE implements @realize, it does > > * not need to implement @init

Re: [Qemu-devel] [PATCH 21/26] kvmclock: use realize for kvmclock

2013-06-24 Thread Hu Tao
On Mon, Jun 24, 2013 at 11:01:54AM -0300, Eduardo Habkost wrote: > On Sat, Jun 22, 2013 at 04:50:33PM +0800, Hu Tao wrote: > > Cc: qemu-devel@nongnu.org > > Cc: "Andreas Färber" > > Cc: Paolo Bonzini > > Cc: Anthony Liguori > > Cc: Igor Mammedov > > Cc: Eduardo Habkost > > Signed-off-by: Hu Ta

Re: [Qemu-devel] [PATCH 21/26] kvmclock: use realize for kvmclock

2013-06-24 Thread Hu Tao
On Mon, Jun 24, 2013 at 12:14:07PM +0200, Igor Mammedov wrote: > On Sat, 22 Jun 2013 16:50:33 +0800 > Hu Tao wrote: > > > Cc: qemu-devel@nongnu.org > > Cc: "Andreas Färber" > > Cc: Paolo Bonzini > > Cc: Anthony Liguori > > Cc: Igor Mammedov > > Cc: Eduardo Habkost > > Signed-off-by: Hu Tao

Re: [Qemu-devel] [PATCH 21/26] kvmclock: use realize for kvmclock

2013-06-24 Thread Eduardo Habkost
On Sat, Jun 22, 2013 at 04:50:33PM +0800, Hu Tao wrote: > Cc: qemu-devel@nongnu.org > Cc: "Andreas Färber" > Cc: Paolo Bonzini > Cc: Anthony Liguori > Cc: Igor Mammedov > Cc: Eduardo Habkost > Signed-off-by: Hu Tao > --- > hw/i386/kvm/clock.c | 8 +++- > 1 file changed, 3 insertions(+),

Re: [Qemu-devel] [PATCH 21/26] kvmclock: use realize for kvmclock

2013-06-24 Thread Igor Mammedov
On Sat, 22 Jun 2013 16:50:33 +0800 Hu Tao wrote: > Cc: qemu-devel@nongnu.org > Cc: "Andreas Färber" > Cc: Paolo Bonzini > Cc: Anthony Liguori > Cc: Igor Mammedov > Cc: Eduardo Habkost > Signed-off-by: Hu Tao > --- > hw/i386/kvm/clock.c | 8 +++- > 1 file changed, 3 insertions(+), 5 del

[Qemu-devel] [PATCH 21/26] kvmclock: use realize for kvmclock

2013-06-22 Thread Hu Tao
Cc: qemu-devel@nongnu.org Cc: "Andreas Färber" Cc: Paolo Bonzini Cc: Anthony Liguori Cc: Igor Mammedov Cc: Eduardo Habkost Signed-off-by: Hu Tao --- hw/i386/kvm/clock.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/hw/i386/kvm/clock.c b/hw/i386/kvm/clock.c index