Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: Test exiting qemu with running job

2017-06-09 Thread Eric Blake
On 06/09/2017 10:55 AM, Kevin Wolf wrote: >> >> These belong in comments in the test proper, because it is not obvious >> otherwise. But with comments added (so someone debugging a theoretical >> test failure down the road knows what they are up against), > > # Note that the reference output int

Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: Test exiting qemu with running job

2017-06-09 Thread Kevin Wolf
Am 09.06.2017 um 16:16 hat Eric Blake geschrieben: > On 06/09/2017 07:58 AM, Kevin Wolf wrote: > > Am 09.06.2017 um 14:14 hat Eric Blake geschrieben: > >> On 06/09/2017 06:50 AM, Kevin Wolf wrote: > >>> When qemu is exited, all running jobs should be cancelled successfully. > >>> This adds a test f

Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: Test exiting qemu with running job

2017-06-09 Thread Eric Blake
On 06/09/2017 07:58 AM, Kevin Wolf wrote: > Am 09.06.2017 um 14:14 hat Eric Blake geschrieben: >> On 06/09/2017 06:50 AM, Kevin Wolf wrote: >>> When qemu is exited, all running jobs should be cancelled successfully. >>> This adds a test for this for all types of block jobs that currently >>> exist

Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: Test exiting qemu with running job

2017-06-09 Thread Kevin Wolf
Am 09.06.2017 um 14:14 hat Eric Blake geschrieben: > On 06/09/2017 06:50 AM, Kevin Wolf wrote: > > When qemu is exited, all running jobs should be cancelled successfully. > > This adds a test for this for all types of block jobs that currently > > exist in qemu. > > > > Signed-off-by: Kevin Wolf

Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: Test exiting qemu with running job

2017-06-09 Thread Eric Blake
On 06/09/2017 06:50 AM, Kevin Wolf wrote: > When qemu is exited, all running jobs should be cancelled successfully. > This adds a test for this for all types of block jobs that currently > exist in qemu. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/185 | 189 > ++

[Qemu-devel] [PATCH 3/3] qemu-iotests: Test exiting qemu with running job

2017-06-09 Thread Kevin Wolf
When qemu is exited, all running jobs should be cancelled successfully. This adds a test for this for all types of block jobs that currently exist in qemu. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/185 | 189 + tests/qemu-iotests/185.out |