Re: [Qemu-devel] [PATCH 3/4] why is runstate_is_running needed?

2015-10-07 Thread Pavel Dovgaluk
I checked this patch. Let's leave it without runstate_is_running() call. If it will be needed later, we'll find it out. Pavel Dovgalyuk > -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Tuesday, October 06, 2015 11:01 PM > T

Re: [Qemu-devel] [PATCH 3/4] why is runstate_is_running needed?

2015-10-07 Thread Paolo Bonzini
On 07/10/2015 10:14, Pavel Dovgaluk wrote: > > It doesn't seem correct to call it for all checkpoints, but why > > is it right for timerlist_run_timers? > > Because replaying shouldn't proceed when machine is stopped. Right, but VIRTUAL and VIRTUAL_RT do not proceed when the machine is stopped.

Re: [Qemu-devel] [PATCH 3/4] why is runstate_is_running needed?

2015-10-07 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Tuesday, October 06, 2015 11:01 PM > To: qemu-devel@nongnu.org > Cc: pavel.dovga...@ispras.ru > Subject: [PATCH 3/4] why is runstate_is_running needed? > > It doesn't seem correct to call it for all checkp

[Qemu-devel] [PATCH 3/4] why is runstate_is_running needed?

2015-10-06 Thread Paolo Bonzini
It doesn't seem correct to call it for all checkpoints, but why is it right for timerlist_run_timers? --- qemu-timer.c | 9 +++-- stubs/replay.c | 5 - 2 files changed, 3 insertions(+), 11 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index 3c6e4c3..f16e422 100644 --- a/qemu-tim