Re: [Qemu-devel] [PATCH 3/6] snapshot: design of common API to take snapshots

2012-12-24 Thread Wenchao Xia
> On 12/16/2012 11:25 PM, Wenchao Xia wrote: This patch added API to take snapshots in unified style for both internal or external type. The core structure is based on transaction, for that there is a qmp interface need to support , qmp_transaction, so all operations are packed as requests.

Re: [Qemu-devel] [PATCH 3/6] snapshot: design of common API to take snapshots

2012-12-24 Thread Wenchao Xia
于 2012-12-22 2:49, Juan Quintela 写道: > Wenchao Xia wrote: >> + >> +typedef struct SNTime { >> +uint32_t date_sec; /* UTC date of the snapshot */ >> +uint32_t date_nsec; > > This two fields are just struct timespec, does it makes sense to use it? > make sense, I did not notice timespec

Re: [Qemu-devel] [PATCH 3/6] snapshot: design of common API to take snapshots

2012-12-21 Thread Juan Quintela
Wenchao Xia wrote: > + > +typedef struct SNTime { > +uint32_t date_sec; /* UTC date of the snapshot */ > +uint32_t date_nsec; This two fields are just struct timespec, does it makes sense to use it? > +uint64_t vm_clock_nsec; /* VM clock relative to boot */ > +} SNTime; > + > +typede

Re: [Qemu-devel] [PATCH 3/6] snapshot: design of common API to take snapshots

2012-12-21 Thread Eric Blake
On 12/16/2012 11:25 PM, Wenchao Xia wrote: > This patch added API to take snapshots in unified style for > both internal or external type. The core structure is based > on transaction, for that there is a qmp interface need to support > , qmp_transaction, so all operations are packed as requests.

[Qemu-devel] [PATCH 3/6] snapshot: design of common API to take snapshots

2012-12-16 Thread Wenchao Xia
This patch added API to take snapshots in unified style for both internal or external type. The core structure is based on transaction, for that there is a qmp interface need to support , qmp_transaction, so all operations are packed as requests. In this way a sperate internal layer for snapsho