Re: [Qemu-devel] [PATCH 33/55] ide/atapi: Avoid physical/virtual tray state mismatch

2011-07-26 Thread Christoph Hellwig
On Wed, Jul 20, 2011 at 06:24:07PM +0200, Markus Armbruster wrote: When ide-cd is backed by a physical drive, we want the physical tray match the virtual one. To that end, we call bdrv_eject() on guest's load/eject, and bdrv_lock_medium() on guest's prevent/allow removal. But we don't set the

Re: [Qemu-devel] [PATCH 33/55] ide/atapi: Avoid physical/virtual tray state mismatch

2011-07-26 Thread Markus Armbruster
Christoph Hellwig h...@lst.de writes: On Wed, Jul 20, 2011 at 06:24:07PM +0200, Markus Armbruster wrote: When ide-cd is backed by a physical drive, we want the physical tray match the virtual one. To that end, we call bdrv_eject() on guest's load/eject, and bdrv_lock_medium() on guest's

[Qemu-devel] [PATCH 33/55] ide/atapi: Avoid physical/virtual tray state mismatch

2011-07-20 Thread Markus Armbruster
When ide-cd is backed by a physical drive, we want the physical tray match the virtual one. To that end, we call bdrv_eject() on guest's load/eject, and bdrv_lock_medium() on guest's prevent/allow removal. But we don't set the initial state on device model init. Fix that. While there, also