Re: [Qemu-devel] [PATCH 4/4] i8254: convert to qdev

2011-03-06 Thread Anthony Liguori
On 03/06/2011 10:47 AM, Blue Swirl wrote: The PIT is not an ISA device. Modelling it as such is worse than leaving it unmodelled. No. These days, PIT is part of Super I/O chip, which is accessed via LPC bus. LPC is from software point of view equal to ISA. Therefore, in absence of LPC, IS

Re: [Qemu-devel] [PATCH 4/4] i8254: convert to qdev

2011-03-06 Thread Blue Swirl
On Sun, Mar 6, 2011 at 6:47 PM, Blue Swirl wrote: > On Sun, Mar 6, 2011 at 6:31 PM, Anthony Liguori wrote: >> On 02/13/2011 03:10 PM, Blue Swirl wrote: >>> >>> Convert to qdev. Don't expose PITState. >>> >>> Signed-off-by: Blue Swirl >>> --- >>>  hw/i8254.c         |   61 >>>

Re: [Qemu-devel] [PATCH 4/4] i8254: convert to qdev

2011-03-06 Thread Blue Swirl
On Sun, Mar 6, 2011 at 6:31 PM, Anthony Liguori wrote: > On 02/13/2011 03:10 PM, Blue Swirl wrote: >> >> Convert to qdev. Don't expose PITState. >> >> Signed-off-by: Blue Swirl >> --- >>  hw/i8254.c         |   61 >> +-- >>  hw/mips_fulong2e.c |    4

Re: [Qemu-devel] [PATCH 4/4] i8254: convert to qdev

2011-03-06 Thread Anthony Liguori
On 02/13/2011 03:10 PM, Blue Swirl wrote: Convert to qdev. Don't expose PITState. Signed-off-by: Blue Swirl --- hw/i8254.c | 61 +-- hw/mips_fulong2e.c |4 +- hw/mips_jazz.c |4 +- hw/mips_malta.c|4 +- hw/mips_r

[Qemu-devel] [PATCH 4/4] i8254: convert to qdev

2011-02-13 Thread Blue Swirl
Convert to qdev. Don't expose PITState. Signed-off-by: Blue Swirl --- hw/i8254.c | 61 +-- hw/mips_fulong2e.c |4 +- hw/mips_jazz.c |4 +- hw/mips_malta.c|4 +- hw/mips_r4k.c |4 +- hw/pc.c|5 +