Re: [Qemu-devel] [PATCH 4/4] linux-user/syscall.c: remove wrong forward decl of setgroups()

2012-12-10 Thread Stefan Weil
Am 10.12.2012 07:59, schrieb John Spencer: this declaration is wrong: the correct prototype on linux is: int setgroups(size_t size, const gid_t *list); since by default musl libc exposes this symbol in unistd.h additionally to grp.h, the wrong declaration causes a build error. the proper fix

[Qemu-devel] [PATCH 4/4] linux-user/syscall.c: remove wrong forward decl of setgroups()

2012-12-09 Thread John Spencer
From 3d9bc5e06ae64806003f8999b4b7ead42bd19c5d Mon Sep 17 00:00:00 2001 From: John Spencer maillist-q...@barfooze.de Date: Mon, 10 Dec 2012 07:02:49 +0100 Subject: [PATCH 4/4] linux-user/syscall.c: remove wrong forward decl of setgroups() this declaration is wrong: the correct prototype on linux

Re: [Qemu-devel] [PATCH 4/4] linux-user/syscall.c: remove wrong forward decl of setgroups()

2012-12-09 Thread Stefan Weil
Am 10.12.2012 07:16, schrieb John Spencer: Your patch is not shown here because you had attached it to your email. Please use git send-email to send patches.See also http://wiki.qemu.org/Contribute/SubmitAPatch. In your patch, you replaced a wrong forward declarationof function setgroups by an

[Qemu-devel] [PATCH 4/4] linux-user/syscall.c: remove wrong forward decl of setgroups()

2012-12-09 Thread John Spencer
this declaration is wrong: the correct prototype on linux is: int setgroups(size_t size, const gid_t *list); since by default musl libc exposes this symbol in unistd.h additionally to grp.h, the wrong declaration causes a build error. the proper fix is to simply include the correct header.

Re: [Qemu-devel] [PATCH 4/4] linux-user/syscall.c: remove wrong forward decl of setgroups()

2012-12-09 Thread John Spencer
On 12/10/2012 07:37 AM, Stefan Weil wrote: Am 10.12.2012 07:16, schrieb John Spencer: Your patch is not shown here because you had attached it to your email. Please use git send-email to send patches.See also http://wiki.qemu.org/Contribute/SubmitAPatch. thanks, resent with git send-email. i