Re: [Qemu-devel] [PATCH 4/5] qemu-io: prompt for encryption keys when required

2015-05-13 Thread Markus Armbruster
Daniel P. Berrange berra...@redhat.com writes: On Tue, May 12, 2015 at 12:32:53PM -0600, Eric Blake wrote: On 05/12/2015 10:09 AM, Daniel P. Berrange wrote: The qemu-io tool does not check if the image is encrypted so historically would silently corrupt the sectors by writing plain text

Re: [Qemu-devel] [PATCH 4/5] qemu-io: prompt for encryption keys when required

2015-05-13 Thread Daniel P. Berrange
On Tue, May 12, 2015 at 12:32:53PM -0600, Eric Blake wrote: On 05/12/2015 10:09 AM, Daniel P. Berrange wrote: The qemu-io tool does not check if the image is encrypted so historically would silently corrupt the sectors by writing plain text data into them instead of cipher text. The earlier

[Qemu-devel] [PATCH 4/5] qemu-io: prompt for encryption keys when required

2015-05-12 Thread Daniel P. Berrange
The qemu-io tool does not check if the image is encrypted so historically would silently corrupt the sectors by writing plain text data into them instead of cipher text. The earlier commit turns this mistake into a fatal abort, so check for encryption and prompt for key when required. This

Re: [Qemu-devel] [PATCH 4/5] qemu-io: prompt for encryption keys when required

2015-05-12 Thread Eric Blake
On 05/12/2015 10:09 AM, Daniel P. Berrange wrote: The qemu-io tool does not check if the image is encrypted so historically would silently corrupt the sectors by writing plain text data into them instead of cipher text. The earlier commit turns this mistake into a fatal abort, so check for