Re: [Qemu-devel] [PATCH 4/7] libcacard: initial commit

2011-03-17 Thread Alon Levy
On Mon, Mar 14, 2011 at 04:20:22PM +0100, Jes Sorensen wrote: On 02/23/11 12:20, Alon Levy wrote: +/* private data for PKI applets */ +typedef struct CACPKIAppletDataStruct { +unsigned char *cert; +int cert_len; +unsigned char *cert_buffer; +int cert_buffer_len; +

Re: [Qemu-devel] [PATCH 4/7] libcacard: initial commit

2011-03-16 Thread Jes Sorensen
On 03/15/11 15:23, Alon Levy wrote: On Tue, Mar 15, 2011 at 08:45:29AM -0500, Anthony Liguori wrote: On 03/15/2011 08:14 AM, Alon Levy wrote: Alternatively the external apps that build against it should be taught to link with the QEMU version. That would require me to teach qemu's configure

Re: [Qemu-devel] [PATCH 4/7] libcacard: initial commit

2011-03-16 Thread Jes Sorensen
On 03/15/11 16:14, Alon Levy wrote: On Tue, Mar 15, 2011 at 03:59:26PM +0100, Jes Sorensen wrote: I don't think it is necessary for distro packaging. Most distros will build multiple binary packages from one source package, and it is up to the user to decide which ones to install. if

Re: [Qemu-devel] [PATCH 4/7] libcacard: initial commit

2011-03-16 Thread Alon Levy
On Wed, Mar 16, 2011 at 09:23:20AM +0100, Jes Sorensen wrote: On 03/15/11 15:23, Alon Levy wrote: On Tue, Mar 15, 2011 at 08:45:29AM -0500, Anthony Liguori wrote: On 03/15/2011 08:14 AM, Alon Levy wrote: Alternatively the external apps that build against it should be taught to link with

Re: [Qemu-devel] [PATCH 4/7] libcacard: initial commit

2011-03-16 Thread Jes Sorensen
On 03/16/11 09:40, Alon Levy wrote: On Wed, Mar 16, 2011 at 09:23:20AM +0100, Jes Sorensen wrote: It's really not far off, most of it is in the Makefiles. You really just need to have a libcacard flag that is enabled per default (and is required if one asks for --enable-smartcard), but can be

Re: [Qemu-devel] [PATCH 4/7] libcacard: initial commit

2011-03-15 Thread Jes Sorensen
On 03/14/11 17:40, Alon Levy wrote: On Mon, Mar 14, 2011 at 04:20:22PM +0100, Jes Sorensen wrote: ok, here is a note where I kinda ignored my own wishes but I want to be very clear on them: libcacard should not be part of qemu. it is here because I once thought it would speed things up.

Re: [Qemu-devel] [PATCH 4/7] libcacard: initial commit

2011-03-15 Thread Alon Levy
On Tue, Mar 15, 2011 at 01:42:56PM +0100, Jes Sorensen wrote: On 03/14/11 17:40, Alon Levy wrote: On Mon, Mar 14, 2011 at 04:20:22PM +0100, Jes Sorensen wrote: ok, here is a note where I kinda ignored my own wishes but I want to be very clear on them: libcacard should not be part of

Re: [Qemu-devel] [PATCH 4/7] libcacard: initial commit

2011-03-15 Thread Jes Sorensen
On 03/15/11 14:14, Alon Levy wrote: On Tue, Mar 15, 2011 at 01:42:56PM +0100, Jes Sorensen wrote: Alternatively the external apps that build against it should be taught to link with the QEMU version. That would require me to teach qemu's configure to build libcacard, possibly only

Re: [Qemu-devel] [PATCH 4/7] libcacard: initial commit

2011-03-15 Thread Anthony Liguori
On 03/15/2011 07:42 AM, Jes Sorensen wrote: On 03/14/11 17:40, Alon Levy wrote: On Mon, Mar 14, 2011 at 04:20:22PM +0100, Jes Sorensen wrote: ok, here is a note where I kinda ignored my own wishes but I want to be very clear on them: libcacard should not be part of qemu. it is here because

Re: [Qemu-devel] [PATCH 4/7] libcacard: initial commit

2011-03-15 Thread Anthony Liguori
On 03/15/2011 08:14 AM, Alon Levy wrote: Alternatively the external apps that build against it should be taught to link with the QEMU version. That would require me to teach qemu's configure to build libcacard, possibly only libcacard (even though qemu doesn't need a lot of packages by

Re: [Qemu-devel] [PATCH 4/7] libcacard: initial commit

2011-03-15 Thread Alon Levy
On Tue, Mar 15, 2011 at 02:40:04PM +0100, Jes Sorensen wrote: On 03/15/11 14:14, Alon Levy wrote: On Tue, Mar 15, 2011 at 01:42:56PM +0100, Jes Sorensen wrote: Alternatively the external apps that build against it should be taught to link with the QEMU version. That would require me

Re: [Qemu-devel] [PATCH 4/7] libcacard: initial commit

2011-03-15 Thread Alon Levy
On Tue, Mar 15, 2011 at 08:45:29AM -0500, Anthony Liguori wrote: On 03/15/2011 08:14 AM, Alon Levy wrote: Alternatively the external apps that build against it should be taught to link with the QEMU version. That would require me to teach qemu's configure to build libcacard, possibly only

Re: [Qemu-devel] [PATCH 4/7] libcacard: initial commit

2011-03-15 Thread Alon Levy
On Tue, Mar 15, 2011 at 08:44:27AM -0500, Anthony Liguori wrote: On 03/15/2011 07:42 AM, Jes Sorensen wrote: On 03/14/11 17:40, Alon Levy wrote: On Mon, Mar 14, 2011 at 04:20:22PM +0100, Jes Sorensen wrote: ok, here is a note where I kinda ignored my own wishes but I want to be very clear

Re: [Qemu-devel] [PATCH 4/7] libcacard: initial commit

2011-03-15 Thread Jes Sorensen
On 03/15/11 15:25, Alon Levy wrote: I am not sure what is the best way, if it stays in QEMU people will eventually start making modifications to it, without looking at the other copy that is being maintained. Two copies is not really practical. QEMU should be the place that owns it

Re: [Qemu-devel] [PATCH 4/7] libcacard: initial commit

2011-03-15 Thread Anthony Liguori
On 03/15/2011 09:25 AM, Alon Levy wrote: On Tue, Mar 15, 2011 at 08:44:27AM -0500, Anthony Liguori wrote: On 03/15/2011 07:42 AM, Jes Sorensen wrote: On 03/14/11 17:40, Alon Levy wrote: On Mon, Mar 14, 2011 at 04:20:22PM +0100, Jes Sorensen wrote: ok, here is a note where I kinda ignored my

Re: [Qemu-devel] [PATCH 4/7] libcacard: initial commit

2011-03-15 Thread Anthony Liguori
On 03/15/2011 09:51 AM, Jes Sorensen wrote: On 03/15/11 15:25, Alon Levy wrote: I am not sure what is the best way, if it stays in QEMU people will eventually start making modifications to it, without looking at the other copy that is being maintained. Two copies is not really practical.

Re: [Qemu-devel] [PATCH 4/7] libcacard: initial commit

2011-03-15 Thread Jes Sorensen
On 03/15/11 15:56, Anthony Liguori wrote: On 03/15/2011 09:51 AM, Jes Sorensen wrote: I don't think we want a --libs option that turns the build process into only producing the libs. No, but you should be able to use options to disable everything but the libs. Likewise, you should be able

Re: [Qemu-devel] [PATCH 4/7] libcacard: initial commit

2011-03-15 Thread Alon Levy
On Tue, Mar 15, 2011 at 03:59:26PM +0100, Jes Sorensen wrote: On 03/15/11 15:56, Anthony Liguori wrote: On 03/15/2011 09:51 AM, Jes Sorensen wrote: I don't think we want a --libs option that turns the build process into only producing the libs. No, but you should be able to use options

Re: [Qemu-devel] [PATCH 4/7] libcacard: initial commit

2011-03-14 Thread Jes Sorensen
On 02/23/11 12:20, Alon Levy wrote: +/* private data for PKI applets */ +typedef struct CACPKIAppletDataStruct { +unsigned char *cert; +int cert_len; +unsigned char *cert_buffer; +int cert_buffer_len; +unsigned char *sign_buffer; +int sign_buffer_len; +VCardKey

Re: [Qemu-devel] [PATCH 4/7] libcacard: initial commit

2011-03-14 Thread Alon Levy
On Mon, Mar 14, 2011 at 04:20:22PM +0100, Jes Sorensen wrote: ok, here is a note where I kinda ignored my own wishes but I want to be very clear on them: libcacard should not be part of qemu. it is here because I once thought it would speed things up. So I'm not taking it out or anything -