Re: [Qemu-devel] [PATCH 4/8] ppc4xx: Use ram_addr_t in ppc4xx_sdram_adjust()

2019-01-07 Thread BALATON Zoltan
On Fri, 4 Jan 2019, David Gibson wrote: On Thu, Jan 03, 2019 at 03:03:20PM +0100, BALATON Zoltan wrote: On Wed, 2 Jan 2019, David Gibson wrote: On Wed, Jan 02, 2019 at 03:06:38AM +0100, BALATON Zoltan wrote: To avoid overflow if larger values are added later use ram_addr_t for the

Re: [Qemu-devel] [PATCH 4/8] ppc4xx: Use ram_addr_t in ppc4xx_sdram_adjust()

2019-01-03 Thread David Gibson
On Thu, Jan 03, 2019 at 03:03:20PM +0100, BALATON Zoltan wrote: > On Wed, 2 Jan 2019, David Gibson wrote: > > On Wed, Jan 02, 2019 at 03:06:38AM +0100, BALATON Zoltan wrote: > > > To avoid overflow if larger values are added later use ram_addr_t for > > > the sdram_bank_sizes parameter to match

Re: [Qemu-devel] [PATCH 4/8] ppc4xx: Use ram_addr_t in ppc4xx_sdram_adjust()

2019-01-03 Thread BALATON Zoltan
On Wed, 2 Jan 2019, David Gibson wrote: On Wed, Jan 02, 2019 at 03:06:38AM +0100, BALATON Zoltan wrote: To avoid overflow if larger values are added later use ram_addr_t for the sdram_bank_sizes parameter to match ram_size to which it is compared. So, technically I think these should be

Re: [Qemu-devel] [PATCH 4/8] ppc4xx: Use ram_addr_t in ppc4xx_sdram_adjust()

2019-01-01 Thread David Gibson
On Wed, Jan 02, 2019 at 03:06:38AM +0100, BALATON Zoltan wrote: > To avoid overflow if larger values are added later use ram_addr_t for > the sdram_bank_sizes parameter to match ram_size to which it is > compared. So, technically I think these should be 'hwaddr' (which represents a guest physical

[Qemu-devel] [PATCH 4/8] ppc4xx: Use ram_addr_t in ppc4xx_sdram_adjust()

2019-01-01 Thread BALATON Zoltan
To avoid overflow if larger values are added later use ram_addr_t for the sdram_bank_sizes parameter to match ram_size to which it is compared. Signed-off-by: BALATON Zoltan --- hw/ppc/ppc440_bamboo.c | 2 +- hw/ppc/ppc4xx_devs.c| 4 ++-- hw/ppc/sam460ex.c | 2 +-