Re: [Qemu-devel] [PATCH 4/9] target/ppc: Fix lxvw4x, lxvh8x and lxvb16x

2019-05-24 Thread Mark Cave-Ayland
On 22/05/2019 07:10, David Gibson wrote: > On Wed, May 22, 2019 at 05:37:47AM +0100, Mark Cave-Ayland wrote: >> On 22/05/2019 01:49, David Gibson wrote: >> >>> On Wed, May 22, 2019 at 06:11:12AM +1000, Anton Blanchard wrote: Hi, > I've now had a bit of time to look through this and

Re: [Qemu-devel] [PATCH 4/9] target/ppc: Fix lxvw4x, lxvh8x and lxvb16x

2019-05-22 Thread David Gibson
On Wed, May 22, 2019 at 05:37:47AM +0100, Mark Cave-Ayland wrote: > On 22/05/2019 01:49, David Gibson wrote: > > > On Wed, May 22, 2019 at 06:11:12AM +1000, Anton Blanchard wrote: > >> Hi, > >> > >>> I've now had a bit of time to look through this and I believe it is > >>> correct, so: > >>> >

Re: [Qemu-devel] [PATCH 4/9] target/ppc: Fix lxvw4x, lxvh8x and lxvb16x

2019-05-21 Thread Mark Cave-Ayland
On 22/05/2019 01:49, David Gibson wrote: > On Wed, May 22, 2019 at 06:11:12AM +1000, Anton Blanchard wrote: >> Hi, >> >>> I've now had a bit of time to look through this and I believe it is >>> correct, so: >>> >>> Reviewed-by: Mark Cave-Ayland >> >> Thanks Mark. David: any chance we could get

Re: [Qemu-devel] [PATCH 4/9] target/ppc: Fix lxvw4x, lxvh8x and lxvb16x

2019-05-21 Thread David Gibson
On Wed, May 22, 2019 at 06:11:12AM +1000, Anton Blanchard wrote: > Hi, > > > I've now had a bit of time to look through this and I believe it is > > correct, so: > > > > Reviewed-by: Mark Cave-Ayland > > Thanks Mark. David: any chance we could get this merged? I can't run a > recent Ubuntu

Re: [Qemu-devel] [PATCH 4/9] target/ppc: Fix lxvw4x, lxvh8x and lxvb16x

2019-05-21 Thread Anton Blanchard
Hi, > I've now had a bit of time to look through this and I believe it is > correct, so: > > Reviewed-by: Mark Cave-Ayland Thanks Mark. David: any chance we could get this merged? I can't run a recent Ubuntu image successfully without it. sshd hangs when I try to ssh into it. Thanks, Anton

Re: [Qemu-devel] [PATCH 4/9] target/ppc: Fix lxvw4x, lxvh8x and lxvb16x

2019-05-10 Thread Mark Cave-Ayland
On 07/05/2019 01:48, Anton Blanchard wrote: > During the conversion these instructions were incorrectly treated as > stores. We need to use set_cpu_vsr* and not get_cpu_vsr*. > > Fixes: 8b3b2d75c7c0 ("introduce get_cpu_vsr{l,h}() and set_cpu_vsr{l,h}() > helpers for VSR register access") >

Re: [Qemu-devel] [PATCH 4/9] target/ppc: Fix lxvw4x, lxvh8x and lxvb16x

2019-05-08 Thread David Gibson
On Thu, May 09, 2019 at 10:33:24AM +1000, Anton Blanchard wrote: > Hi Mark, > > > Following on from this I've just gone through the load/store > > operations once again and spotted two things: > > > > > > 1) VSX_LOAD_SCALAR_DS has an extra get_cpu_vsrh() which can be removed > > > > diff --git

Re: [Qemu-devel] [PATCH 4/9] target/ppc: Fix lxvw4x, lxvh8x and lxvb16x

2019-05-08 Thread Anton Blanchard
Hi Mark, > Following on from this I've just gone through the load/store > operations once again and spotted two things: > > > 1) VSX_LOAD_SCALAR_DS has an extra get_cpu_vsrh() which can be removed > > diff --git a/target/ppc/translate/vsx-impl.inc.c > b/target/ppc/translate/vsx-impl.inc.c

Re: [Qemu-devel] [PATCH 4/9] target/ppc: Fix lxvw4x, lxvh8x and lxvb16x

2019-05-07 Thread Mark Cave-Ayland
On 07/05/2019 06:28, David Gibson wrote: > On Tue, May 07, 2019 at 10:48:06AM +1000, Anton Blanchard wrote: >> During the conversion these instructions were incorrectly treated as >> stores. We need to use set_cpu_vsr* and not get_cpu_vsr*. >> >> Fixes: 8b3b2d75c7c0 ("introduce get_cpu_vsr{l,h}()

Re: [Qemu-devel] [PATCH 4/9] target/ppc: Fix lxvw4x, lxvh8x and lxvb16x

2019-05-07 Thread David Gibson
On Tue, May 07, 2019 at 10:48:06AM +1000, Anton Blanchard wrote: > During the conversion these instructions were incorrectly treated as > stores. We need to use set_cpu_vsr* and not get_cpu_vsr*. > > Fixes: 8b3b2d75c7c0 ("introduce get_cpu_vsr{l,h}() and set_cpu_vsr{l,h}() > helpers for VSR

[Qemu-devel] [PATCH 4/9] target/ppc: Fix lxvw4x, lxvh8x and lxvb16x

2019-05-06 Thread Anton Blanchard
During the conversion these instructions were incorrectly treated as stores. We need to use set_cpu_vsr* and not get_cpu_vsr*. Fixes: 8b3b2d75c7c0 ("introduce get_cpu_vsr{l,h}() and set_cpu_vsr{l,h}() helpers for VSR register access") Signed-off-by: Anton Blanchard ---