Re: [Qemu-devel] [PATCH 5/9] linux-user: Fix epoll on ARM hosts

2013-07-06 Thread Peter Maydell
On 6 July 2013 01:36, Alexander Graf ag...@suse.de wrote: diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h index 8b06a19..fbc3cac 100644 --- a/linux-user/syscall_defs.h +++ b/linux-user/syscall_defs.h @@ -2434,8 +2434,11 @@ typedef union target_epoll_data { struct

Re: [Qemu-devel] [PATCH 5/9] linux-user: Fix epoll on ARM hosts

2013-07-06 Thread Alexander Graf
On 06.07.2013, at 12:45, Peter Maydell wrote: On 6 July 2013 01:36, Alexander Graf ag...@suse.de wrote: diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h index 8b06a19..fbc3cac 100644 --- a/linux-user/syscall_defs.h +++ b/linux-user/syscall_defs.h @@ -2434,8 +2434,11 @@

[Qemu-devel] [PATCH 5/9] linux-user: Fix epoll on ARM hosts

2013-07-06 Thread Alexander Graf
The epoll emulation uses data structures without packing them, so the compiler might choose to add padding inside. This patch makes the most offending one (target_epoll_event) a packed structure to make sure we don't pad it by accident. ARM would pad it, so declare the padding mandatory for ARM

[Qemu-devel] [PATCH 5/9] linux-user: Fix epoll on ARM hosts

2013-07-05 Thread Alexander Graf
The epoll emulation uses data structures without packing them, so the compiler might choose to add padding inside. This patch makes the most offending one (target_epoll_event) a packed structure to make sure we don't pad it by accident. ARM would pad it, so declare the padding mandatory for ARM