On 03/23/2016 04:12 PM, Markus Armbruster wrote:
Cao jin writes:
Really appreciate your review, I just finished reading all the
comments and discussion.
Seems pci_add_capability2()(commit cd9aa33e introduced) doesn`t follow
the new error reporting rule(report error while also return erro
Cao jin writes:
> On 03/02/2016 05:13 PM, Markus Armbruster wrote:
>> This got lost over the Christmas break, sorry.
>>
>> Cc'ing Marcel for additional PCI expertise.
>>
>> Cao jin writes:
>>
>>> msi_init() is a supporting function in PCI device initialization,
>>> in order to convert .init() to
On 03/02/2016 05:13 PM, Markus Armbruster wrote:
This got lost over the Christmas break, sorry.
Cc'ing Marcel for additional PCI expertise.
Cao jin writes:
msi_init() is a supporting function in PCI device initialization,
in order to convert .init() to .realize(), it should be modified firs
On Fri, Mar 04, 2016 at 01:57:05PM +0100, Markus Armbruster wrote:
> "Michael S. Tsirkin" writes:
>
> > On Fri, Mar 04, 2016 at 09:42:02AM +0100, Markus Armbruster wrote:
> >> Plugging an MSI-capable device into an MSI-incapable board works just
> >> fine, both for physical and for virtual hardwa
"Michael S. Tsirkin" writes:
> On Fri, Mar 04, 2016 at 09:42:02AM +0100, Markus Armbruster wrote:
>> Plugging an MSI-capable device into an MSI-incapable board works just
>> fine, both for physical and for virtual hardware. What doesn't work is
>> plugging an MSI-capable device into an MSI-capab
On Fri, Mar 04, 2016 at 09:42:02AM +0100, Markus Armbruster wrote:
> Plugging an MSI-capable device into an MSI-incapable board works just
> fine, both for physical and for virtual hardware. What doesn't work is
> plugging an MSI-capable device into an MSI-capable board with *broken*
> MSI support
"Michael S. Tsirkin" writes:
> On Thu, Mar 03, 2016 at 04:03:16PM +0100, Markus Armbruster wrote:
>> "Michael S. Tsirkin" writes:
>>
>> > On Thu, Mar 03, 2016 at 01:19:09PM +0200, Marcel Apfelbaum wrote:
>> >> On 03/03/2016 12:45 PM, Michael S. Tsirkin wrote:
>> >> >On Thu, Mar 03, 2016 at 12:1
On Thu, Mar 03, 2016 at 04:03:16PM +0100, Markus Armbruster wrote:
> "Michael S. Tsirkin" writes:
>
> > On Thu, Mar 03, 2016 at 01:19:09PM +0200, Marcel Apfelbaum wrote:
> >> On 03/03/2016 12:45 PM, Michael S. Tsirkin wrote:
> >> >On Thu, Mar 03, 2016 at 12:12:27PM +0200, Marcel Apfelbaum wrote:
"Michael S. Tsirkin" writes:
> On Thu, Mar 03, 2016 at 01:19:09PM +0200, Marcel Apfelbaum wrote:
>> On 03/03/2016 12:45 PM, Michael S. Tsirkin wrote:
>> >On Thu, Mar 03, 2016 at 12:12:27PM +0200, Marcel Apfelbaum wrote:
>> +int msi_init(struct PCIDevice *dev, uint8_t offset, unsigned int
>>
Marcel Apfelbaum writes:
> On 03/02/2016 11:13 AM, Markus Armbruster wrote:
>> This got lost over the Christmas break, sorry.
>>
>> Cc'ing Marcel for additional PCI expertise.
>>
>> Cao jin writes:
>>
>>> msi_init() is a supporting function in PCI device initialization,
>>> in order to convert .
On Thu, Mar 03, 2016 at 01:19:09PM +0200, Marcel Apfelbaum wrote:
> On 03/03/2016 12:45 PM, Michael S. Tsirkin wrote:
> >On Thu, Mar 03, 2016 at 12:12:27PM +0200, Marcel Apfelbaum wrote:
> +int msi_init(struct PCIDevice *dev, uint8_t offset, unsigned int
> nr_vectors,
> + b
On 03/03/2016 12:45 PM, Michael S. Tsirkin wrote:
On Thu, Mar 03, 2016 at 12:12:27PM +0200, Marcel Apfelbaum wrote:
+int msi_init(struct PCIDevice *dev, uint8_t offset, unsigned int nr_vectors,
+ bool msi64bit, bool msi_per_vector_mask, Error **errp)
{
unsigned int vectors_or
On Thu, Mar 03, 2016 at 12:12:27PM +0200, Marcel Apfelbaum wrote:
> >>+int msi_init(struct PCIDevice *dev, uint8_t offset, unsigned int
> >>nr_vectors,
> >>+ bool msi64bit, bool msi_per_vector_mask, Error **errp)
> >> {
> >> unsigned int vectors_order;
> >>-uint16_t flags;
>
On 03/02/2016 11:13 AM, Markus Armbruster wrote:
This got lost over the Christmas break, sorry.
Cc'ing Marcel for additional PCI expertise.
Cao jin writes:
msi_init() is a supporting function in PCI device initialization,
in order to convert .init() to .realize(), it should be modified first
hi, Markus
Thanks for still remembering this patch, and quite a lot response:)
I will give a appropriate response after I read & understand them
all.(so, not cc other guys here)
On 03/02/2016 05:13 PM, Markus Armbruster wrote:
This got lost over the Christmas break, sorry.
Cc'ing Marcel for a
This got lost over the Christmas break, sorry.
Cc'ing Marcel for additional PCI expertise.
Cao jin writes:
> msi_init() is a supporting function in PCI device initialization,
> in order to convert .init() to .realize(), it should be modified first.
"Supporting function" doesn't imply "should u
msi_init() is a supporting function in PCI device initialization,
in order to convert .init() to .realize(), it should be modified first.
Also modify the callers
Bonus: add more comment for msi_init().
Signed-off-by: Cao jin
---
hw/audio/intel-hda.c | 10 -
hw/ide/ich.c
17 matches
Mail list logo