Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-02-01 Thread Dr. David Alan Gilbert
* Wei Huang (w...@redhat.com) wrote: > > > On 01/25/2018 02:05 PM, Dr. David Alan Gilbert wrote: > > * Wei Huang (w...@redhat.com) wrote: > >> This patch adds the migration test support for aarch64. The test code, > >> which implements the same functionality as x86, is compiled into a binary > >>

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-02-01 Thread Christoffer Dall
On Thu, Feb 01, 2018 at 01:25:20PM +0100, Andrew Jones wrote: > On Thu, Feb 01, 2018 at 11:48:31AM +0100, Christoffer Dall wrote: > > On Thu, Feb 01, 2018 at 11:42:22AM +0100, Andrew Jones wrote: > > > On Thu, Feb 01, 2018 at 10:59:54AM +0100, Christoffer Dall wrote: > > > > On Thu, Feb 1, 2018 at

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-02-01 Thread Andrew Jones
On Thu, Feb 01, 2018 at 11:48:31AM +0100, Christoffer Dall wrote: > On Thu, Feb 01, 2018 at 11:42:22AM +0100, Andrew Jones wrote: > > On Thu, Feb 01, 2018 at 10:59:54AM +0100, Christoffer Dall wrote: > > > On Thu, Feb 1, 2018 at 10:33 AM, Ard Biesheuvel > > > > If you could use dirty page tracking

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-02-01 Thread Christoffer Dall
On Thu, Feb 01, 2018 at 11:42:22AM +0100, Andrew Jones wrote: > On Thu, Feb 01, 2018 at 10:59:54AM +0100, Christoffer Dall wrote: > > On Thu, Feb 1, 2018 at 10:33 AM, Ard Biesheuvel > > wrote: > > > On 1 February 2018 at 09:17, Christoffer Dall > > > wrote: > > >> On Wed, Jan 31, 2018 at 9:15 PM,

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-02-01 Thread Andrew Jones
On Thu, Feb 01, 2018 at 10:59:54AM +0100, Christoffer Dall wrote: > On Thu, Feb 1, 2018 at 10:33 AM, Ard Biesheuvel > wrote: > > On 1 February 2018 at 09:17, Christoffer Dall > > wrote: > >> On Wed, Jan 31, 2018 at 9:15 PM, Ard Biesheuvel > >> wrote: > >>> On 31 January 2018 at 19:12, Christoffe

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-02-01 Thread Ard Biesheuvel
On 1 February 2018 at 09:59, Christoffer Dall wrote: > On Thu, Feb 1, 2018 at 10:33 AM, Ard Biesheuvel > wrote: >> On 1 February 2018 at 09:17, Christoffer Dall >> wrote: ... >>> >>> Unless I'm missing something fundamental, I think we should add >>> functionality in QEMU to clean+invalidate pag

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-02-01 Thread Christoffer Dall
On Thu, Feb 1, 2018 at 10:33 AM, Ard Biesheuvel wrote: > On 1 February 2018 at 09:17, Christoffer Dall > wrote: >> On Wed, Jan 31, 2018 at 9:15 PM, Ard Biesheuvel >> wrote: >>> On 31 January 2018 at 19:12, Christoffer Dall >>> wrote: On Wed, Jan 31, 2018 at 7:00 PM, Ard Biesheuvel wr

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-02-01 Thread Ard Biesheuvel
On 1 February 2018 at 09:17, Christoffer Dall wrote: > On Wed, Jan 31, 2018 at 9:15 PM, Ard Biesheuvel > wrote: >> On 31 January 2018 at 19:12, Christoffer Dall >> wrote: >>> On Wed, Jan 31, 2018 at 7:00 PM, Ard Biesheuvel >>> wrote: On 31 January 2018 at 17:39, Christoffer Dall wrot

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-02-01 Thread Christoffer Dall
On Wed, Jan 31, 2018 at 9:15 PM, Ard Biesheuvel wrote: > On 31 January 2018 at 19:12, Christoffer Dall > wrote: >> On Wed, Jan 31, 2018 at 7:00 PM, Ard Biesheuvel >> wrote: >>> On 31 January 2018 at 17:39, Christoffer Dall >>> wrote: On Wed, Jan 31, 2018 at 5:59 PM, Ard Biesheuvel wr

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-01-31 Thread Ard Biesheuvel
On 31 January 2018 at 19:12, Christoffer Dall wrote: > On Wed, Jan 31, 2018 at 7:00 PM, Ard Biesheuvel > wrote: >> On 31 January 2018 at 17:39, Christoffer Dall >> wrote: >>> On Wed, Jan 31, 2018 at 5:59 PM, Ard Biesheuvel >>> wrote: On 31 January 2018 at 16:53, Christoffer Dall wrot

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-01-31 Thread Christoffer Dall
On Wed, Jan 31, 2018 at 7:00 PM, Ard Biesheuvel wrote: > On 31 January 2018 at 17:39, Christoffer Dall > wrote: >> On Wed, Jan 31, 2018 at 5:59 PM, Ard Biesheuvel >> wrote: >>> On 31 January 2018 at 16:53, Christoffer Dall >>> wrote: On Wed, Jan 31, 2018 at 4:18 PM, Ard Biesheuvel wr

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-01-31 Thread Ard Biesheuvel
On 31 January 2018 at 17:39, Christoffer Dall wrote: > On Wed, Jan 31, 2018 at 5:59 PM, Ard Biesheuvel > wrote: >> On 31 January 2018 at 16:53, Christoffer Dall >> wrote: >>> On Wed, Jan 31, 2018 at 4:18 PM, Ard Biesheuvel >>> wrote: On 31 January 2018 at 09:53, Christoffer Dall wrot

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-01-31 Thread Christoffer Dall
On Wed, Jan 31, 2018 at 5:59 PM, Ard Biesheuvel wrote: > On 31 January 2018 at 16:53, Christoffer Dall > wrote: >> On Wed, Jan 31, 2018 at 4:18 PM, Ard Biesheuvel >> wrote: >>> On 31 January 2018 at 09:53, Christoffer Dall >>> wrote: On Mon, Jan 29, 2018 at 10:32:12AM +, Marc Zyngier w

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-01-31 Thread Ard Biesheuvel
On 31 January 2018 at 16:53, Christoffer Dall wrote: > On Wed, Jan 31, 2018 at 4:18 PM, Ard Biesheuvel > wrote: >> On 31 January 2018 at 09:53, Christoffer Dall >> wrote: >>> On Mon, Jan 29, 2018 at 10:32:12AM +, Marc Zyngier wrote: On 29/01/18 10:04, Peter Maydell wrote: > On 29 J

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-01-31 Thread Christoffer Dall
On Wed, Jan 31, 2018 at 4:18 PM, Ard Biesheuvel wrote: > On 31 January 2018 at 09:53, Christoffer Dall > wrote: >> On Mon, Jan 29, 2018 at 10:32:12AM +, Marc Zyngier wrote: >>> On 29/01/18 10:04, Peter Maydell wrote: >>> > On 29 January 2018 at 09:53, Dr. David Alan Gilbert >>> > wrote: >>>

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-01-31 Thread Dr. David Alan Gilbert
* Ard Biesheuvel (ard.biesheu...@linaro.org) wrote: > On 31 January 2018 at 09:53, Christoffer Dall > wrote: > > On Mon, Jan 29, 2018 at 10:32:12AM +, Marc Zyngier wrote: > >> On 29/01/18 10:04, Peter Maydell wrote: > >> > On 29 January 2018 at 09:53, Dr. David Alan Gilbert > >> > wrote: > >

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-01-31 Thread Ard Biesheuvel
On 31 January 2018 at 09:53, Christoffer Dall wrote: > On Mon, Jan 29, 2018 at 10:32:12AM +, Marc Zyngier wrote: >> On 29/01/18 10:04, Peter Maydell wrote: >> > On 29 January 2018 at 09:53, Dr. David Alan Gilbert >> > wrote: >> >> * Peter Maydell (peter.mayd...@linaro.org) wrote: >> >>> On 2

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-01-31 Thread Christoffer Dall
On Mon, Jan 29, 2018 at 10:32:12AM +, Marc Zyngier wrote: > On 29/01/18 10:04, Peter Maydell wrote: > > On 29 January 2018 at 09:53, Dr. David Alan Gilbert > > wrote: > >> * Peter Maydell (peter.mayd...@linaro.org) wrote: > >>> On 26 January 2018 at 19:46, Dr. David Alan Gilbert > >>> wrote

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-01-29 Thread Marc Zyngier
On 29/01/18 10:04, Peter Maydell wrote: > On 29 January 2018 at 09:53, Dr. David Alan Gilbert > wrote: >> * Peter Maydell (peter.mayd...@linaro.org) wrote: >>> On 26 January 2018 at 19:46, Dr. David Alan Gilbert >>> wrote: * Peter Maydell (peter.mayd...@linaro.org) wrote: > I think the

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-01-29 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 29 January 2018 at 09:53, Dr. David Alan Gilbert > wrote: > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > >> On 26 January 2018 at 19:46, Dr. David Alan Gilbert > >> wrote: > >> > * Peter Maydell (peter.mayd...@linaro.org) wrote: >

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-01-29 Thread Peter Maydell
On 29 January 2018 at 09:53, Dr. David Alan Gilbert wrote: > * Peter Maydell (peter.mayd...@linaro.org) wrote: >> On 26 January 2018 at 19:46, Dr. David Alan Gilbert >> wrote: >> > * Peter Maydell (peter.mayd...@linaro.org) wrote: >> >> I think the correct fix here is that your test code should

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-01-29 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 26 January 2018 at 19:46, Dr. David Alan Gilbert > wrote: > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > >> I think the correct fix here is that your test code should turn > >> its MMU on. Trying to treat guest RAM as uncacheable doe

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-01-28 Thread Peter Maydell
On 26 January 2018 at 19:46, Dr. David Alan Gilbert wrote: > * Peter Maydell (peter.mayd...@linaro.org) wrote: >> I think the correct fix here is that your test code should turn >> its MMU on. Trying to treat guest RAM as uncacheable doesn't work >> for Arm KVM guests (for the same reason that VGA

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-01-26 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 26 January 2018 at 15:47, Wei Huang wrote: > > > > > > On 01/25/2018 02:05 PM, Dr. David Alan Gilbert wrote: > >> * Wei Huang (w...@redhat.com) wrote: > >>> innerloop: > >>> /* clean cache because el2 might still cache guest data under

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-01-26 Thread Wei Huang
On 01/26/2018 10:39 AM, Peter Maydell wrote: > On 26 January 2018 at 15:47, Wei Huang wrote: >> >> >> On 01/25/2018 02:05 PM, Dr. David Alan Gilbert wrote: >>> * Wei Huang (w...@redhat.com) wrote: innerloop: /* clean cache because el2 might still cache guest data under KVM >>>

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-01-26 Thread Peter Maydell
On 26 January 2018 at 15:47, Wei Huang wrote: > > > On 01/25/2018 02:05 PM, Dr. David Alan Gilbert wrote: >> * Wei Huang (w...@redhat.com) wrote: >>> innerloop: >>> /* clean cache because el2 might still cache guest data under KVM */ >>> dc civac, x2 >> >> Can you explain a bi

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-01-26 Thread Wei Huang
On 01/25/2018 02:05 PM, Dr. David Alan Gilbert wrote: > * Wei Huang (w...@redhat.com) wrote: >> This patch adds the migration test support for aarch64. The test code, >> which implements the same functionality as x86, is compiled into a binary >> and booted as a kernel in qemu. Here are the desig

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-01-25 Thread Dr. David Alan Gilbert
* Wei Huang (w...@redhat.com) wrote: > This patch adds the migration test support for aarch64. The test code, > which implements the same functionality as x86, is compiled into a binary > and booted as a kernel in qemu. Here are the design ideas: > > * We choose this -kernel design because aarch6

[Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-01-24 Thread Wei Huang
This patch adds the migration test support for aarch64. The test code, which implements the same functionality as x86, is compiled into a binary and booted as a kernel in qemu. Here are the design ideas: * We choose this -kernel design because aarch64 QEMU doesn't provide a built-in fw like x8