Re: [Qemu-devel] [PATCH V18 01/25] qemu-option: add def_value_str in QemuOptDesc struct and rewrite qemu_opts_print

2013-08-28 Thread Dong Xu Wang
On 2013/8/28 20:53, Eric Blake wrote: On 08/12/2013 10:31 PM, Dong Xu Wang wrote: qemu_opts_print has no user now, so can re-write the function safely. qemu_opts_print is used while using "qemu-img create", it produces the same output as previous code. The behavior of this function has changed

Re: [Qemu-devel] [PATCH V18 01/25] qemu-option: add def_value_str in QemuOptDesc struct and rewrite qemu_opts_print

2013-08-28 Thread Eric Blake
On 08/12/2013 10:31 PM, Dong Xu Wang wrote: > qemu_opts_print has no user now, so can re-write the function safely. > > qemu_opts_print is used while using "qemu-img create", it > produces the same output as previous code. > > The behavior of this function has changed: > > 1. Print every possibl

Re: [Qemu-devel] [PATCH V18 01/25] qemu-option: add def_value_str in QemuOptDesc struct and rewrite qemu_opts_print

2013-08-28 Thread Dong Xu Wang
On 2013/8/27 21:49, Kevin Wolf wrote: Am 13.08.2013 um 06:31 hat Dong Xu Wang geschrieben: qemu_opts_print has no user now, so can re-write the function safely. qemu_opts_print is used while using "qemu-img create", it produces the same output as previous code. The behavior of this function ha

Re: [Qemu-devel] [PATCH V18 01/25] qemu-option: add def_value_str in QemuOptDesc struct and rewrite qemu_opts_print

2013-08-27 Thread Kevin Wolf
Am 13.08.2013 um 06:31 hat Dong Xu Wang geschrieben: > qemu_opts_print has no user now, so can re-write the function safely. > > qemu_opts_print is used while using "qemu-img create", it > produces the same output as previous code. > > The behavior of this function has changed: > > 1. Print ever

[Qemu-devel] [PATCH V18 01/25] qemu-option: add def_value_str in QemuOptDesc struct and rewrite qemu_opts_print

2013-08-12 Thread Dong Xu Wang
qemu_opts_print has no user now, so can re-write the function safely. qemu_opts_print is used while using "qemu-img create", it produces the same output as previous code. The behavior of this function has changed: 1. Print every possible option, whether a value has been set or not. 2. Option des