Let me add my two cents here. I tested this patch slightly and didn't
find any problems.
On 2012-03-15 11:35, Igor Mitsyanko wrote:
> Create 9 exynos4210 i2c interfaces.
>
> Signed-off-by: Igor Mitsyanko
> ---
> Makefile.target |1 +
> hw/exynos4210.c | 26 +++
> hw/exynos4210.h
On 04/03/2012 05:54 PM, Dmitry Zhurikhin wrote:
Let me add my two cents here. I tested this patch slightly and didn't
find any problems.
Great, thanks!
On 2012-03-15 11:35, Igor Mitsyanko wrote:
Create 9 exynos4210 i2c interfaces.
Signed-off-by: Igor Mitsyanko
---
Makefile.target |
On 21 March 2012 14:18, Igor Mitsyanko wrote:
> Do you mean we shouldn't register EXYNOS4_I2C_SLAVE at all so some
> hypothetical bus master wouldn't even find EXYNOS4_I2C_SLAVE on a bus?
> Maybe the best solution is to make exynos4210_i2c_slave_send() and
> exynos4210_i2c_slave_recv() always retu
On 03/21/2012 05:09 PM, Peter Maydell wrote:
On 21 March 2012 13:07, Igor Mitsyanko wrote:
On 03/21/2012 03:55 PM, Peter Maydell wrote:
I suspect that what's happening here is that the hardware
lets you put the i2c controller into slave mode so some
other device on the bus can be a master. But
On 03/21/2012 03:55 PM, Peter Maydell wrote:
On 15 March 2012 07:35, Igor Mitsyanko wrote:
Create 9 exynos4210 i2c interfaces.
Signed-off-by: Igor Mitsyanko
Mostly this looks OK but I still find the i2c slave stuff
odd -- should the controller really register itself as
a slave on its own bus
On 21 March 2012 13:07, Igor Mitsyanko wrote:
> On 03/21/2012 03:55 PM, Peter Maydell wrote:
>> I suspect that what's happening here is that the hardware
>> lets you put the i2c controller into slave mode so some
>> other device on the bus can be a master. But QEMU's
>> i2c bus abstraction doesn't
On 15 March 2012 07:35, Igor Mitsyanko wrote:
> Create 9 exynos4210 i2c interfaces.
>
> Signed-off-by: Igor Mitsyanko
Mostly this looks OK but I still find the i2c slave stuff
odd -- should the controller really register itself as
a slave on its own bus? Doesn't this mean that the
controller can
Am 15.03.2012 08:35, schrieb Igor Mitsyanko:
> Create 9 exynos4210 i2c interfaces.
>
> Signed-off-by: Igor Mitsyanko
Reviewed-by: Andreas Färber
for the non-technical aspects. One remark below.
> diff --git a/hw/exynos4210_i2c.c b/hw/exynos4210_i2c.c
> new file mode 100644
> index 000..42
Create 9 exynos4210 i2c interfaces.
Signed-off-by: Igor Mitsyanko
---
Makefile.target |1 +
hw/exynos4210.c | 26 +++
hw/exynos4210.h |3 +
hw/exynos4210_i2c.c | 469 +++
4 files changed, 499 insertions(+), 0 deletions(-)
cr
