Re: [Qemu-devel] [PATCH V3] net/colo-compare.c: Fix memory leak and code style issue.

2019-07-21 Thread Zhang, Chen
Sorry, I re-sent the old version. Please redirect to V4 patch. Thanks Zhang Chen > -Original Message- > From: Zhang, Chen > Sent: Thursday, July 18, 2019 5:22 PM > To: Li Zhijian ; Peter Maydell > ; Jason Wang ; qemu-dev > > Cc: Zhang Chen ; Zhang, Chen > Subject: [PATCH V3] net/colo-co

Re: [Qemu-devel] [PATCH V3] net/colo-compare.c: Fix memory leak and code style issue.

2019-07-18 Thread Zhang, Chen
> -Original Message- > From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com] > Sent: Thursday, July 18, 2019 6:54 PM > To: Peter Maydell > Cc: Zhang, Chen ; Li Zhijian ; > Jason Wang ; qemu-dev ; > Zhang Chen > Subject: Re: [Qemu-devel] [PATCH V3] net/colo-co

Re: [Qemu-devel] [PATCH V3] net/colo-compare.c: Fix memory leak and code style issue.

2019-07-18 Thread Zhang, Chen
> -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Thursday, July 18, 2019 9:42 PM > To: Zhang, Chen > Cc: Li Zhijian ; Jason Wang ; > qemu-dev ; Zhang Chen > Subject: Re: [PATCH V3] net/colo-compare.c: Fix memory leak and code style > issue. > > On Thu

Re: [Qemu-devel] [PATCH V3] net/colo-compare.c: Fix memory leak and code style issue.

2019-07-18 Thread Peter Maydell
On Thu, 18 Jul 2019 at 10:27, Zhang Chen wrote: > > From: Zhang Chen > > This patch to fix the origin "char *data" menory leak, code style issue > and add necessary check here. > Reported-by: Coverity (CID 1402785) > > Signed-off-by: Zhang Chen > --- > net/colo-compare.c | 28 ++

Re: [Qemu-devel] [PATCH V3] net/colo-compare.c: Fix memory leak and code style issue.

2019-07-18 Thread Philippe Mathieu-Daudé
On 7/18/19 12:37 PM, Peter Maydell wrote: > On Thu, 18 Jul 2019 at 11:28, Philippe Mathieu-Daudé > wrote: >> >> On 7/18/19 11:22 AM, Zhang Chen wrote: >>> From: Zhang Chen >>> >>> This patch to fix the origin "char *data" menory leak, code style issue >> >> "memory" >> >>> and add necessary chec

Re: [Qemu-devel] [PATCH V3] net/colo-compare.c: Fix memory leak and code style issue.

2019-07-18 Thread Peter Maydell
On Thu, 18 Jul 2019 at 11:28, Philippe Mathieu-Daudé wrote: > > On 7/18/19 11:22 AM, Zhang Chen wrote: > > From: Zhang Chen > > > > This patch to fix the origin "char *data" menory leak, code style issue > > "memory" > > > and add necessary check here. > > Reported-by: Coverity (CID 1402785) > >

Re: [Qemu-devel] [PATCH V3] net/colo-compare.c: Fix memory leak and code style issue.

2019-07-18 Thread Philippe Mathieu-Daudé
On 7/18/19 11:22 AM, Zhang Chen wrote: > From: Zhang Chen > > This patch to fix the origin "char *data" menory leak, code style issue "memory" > and add necessary check here. > Reported-by: Coverity (CID 1402785) > > Signed-off-by: Zhang Chen > --- > net/colo-compare.c | 28 +

[Qemu-devel] [PATCH V3] net/colo-compare.c: Fix memory leak and code style issue.

2019-07-18 Thread Zhang Chen
From: Zhang Chen This patch to fix the origin "char *data" menory leak, code style issue and add necessary check here. Reported-by: Coverity (CID 1402785) Signed-off-by: Zhang Chen --- net/colo-compare.c | 28 +--- 1 file changed, 21 insertions(+), 7 deletions(-) diff