Re: [Qemu-devel] [PATCH V4 1/2] qapi: Add SnapshotInfo and ImageInfo.

2012-08-23 Thread Benoît Canet
That seems backwards - with a raw file, don't you know the actual size, but have no idea what it can further grow to? In raw it commes from fstat() with the field st.st_blocks. from man: blkcnt_t st_blocks; /* number of 512B blocks allocated */ Benoît

Re: [Qemu-devel] [PATCH V4 1/2] qapi: Add SnapshotInfo and ImageInfo.

2012-08-23 Thread Benoît Canet
+## +# @ImageInfo: +# +# Information about a QEMU image file +# +# @filename: name of the image file +# +# @format: format of the image file +# +# @virtual-size: maximum capacity in bytes of the image +# +# @actual-size: #optional actual size on disk in bytes of the image

[Qemu-devel] [PATCH V4 1/2] qapi: Add SnapshotInfo and ImageInfo.

2012-08-22 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- qapi-schema.json | 62 ++ 1 file changed, 62 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index a92adb1..4c4b9b9 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@

Re: [Qemu-devel] [PATCH V4 1/2] qapi: Add SnapshotInfo and ImageInfo.

2012-08-22 Thread Eric Blake
On 08/22/2012 06:45 AM, Benoît Canet wrote: Signed-off-by: Benoit Canet ben...@irqsave.net --- qapi-schema.json | 62 ++ 1 file changed, 62 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index a92adb1..4c4b9b9 100644

Re: [Qemu-devel] [PATCH V4 1/2] qapi: Add SnapshotInfo and ImageInfo.

2012-08-22 Thread Benoît Canet
Le Wednesday 22 Aug 2012 à 08:03:14 (-0600), Eric Blake a écrit : On 08/22/2012 06:45 AM, Benoît Canet wrote: Signed-off-by: Benoit Canet ben...@irqsave.net --- qapi-schema.json | 62 ++ 1 file changed, 62 insertions(+) diff

Re: [Qemu-devel] [PATCH V4 1/2] qapi: Add SnapshotInfo and ImageInfo.

2012-08-22 Thread Eric Blake
On 08/22/2012 08:32 AM, Benoît Canet wrote: Since we have two fields named *-nsec, it might be worth clarifying that date-nsec is merely the fractional portion to be combined with date-sec (always less than 10), while vm-clock-nsec includes seconds if the drift is that large. For

Re: [Qemu-devel] [PATCH V4 1/2] qapi: Add SnapshotInfo and ImageInfo.

2012-08-22 Thread Benoît Canet
Le Wednesday 22 Aug 2012 à 08:56:06 (-0600), Eric Blake a écrit : On 08/22/2012 08:32 AM, Benoît Canet wrote: Since we have two fields named *-nsec, it might be worth clarifying that date-nsec is merely the fractional portion to be combined with date-sec (always less than 10), while