[Qemu-devel] [PATCH V9 01/14] block: move bdrv_snapshot_find() to block/snapshot.c

2013-03-11 Thread Wenchao Xia
This patch adds block/snapshot.c and then moves the function there. It also fixes small code style errors reported by check script. Signed-off-by: Wenchao Xia --- block/Makefile.objs |1 + block/snapshot.c | 37 + include/block/snapshot.h

Re: [Qemu-devel] [PATCH V9 01/14] block: move bdrv_snapshot_find() to block/snapshot.c

2013-03-11 Thread Eric Blake
On 03/11/2013 05:23 AM, Wenchao Xia wrote: > This patch adds block/snapshot.c and then moves the function > there. It also fixes small code style errors reported by check script. > > Signed-off-by: Wenchao Xia > --- > block/Makefile.objs |1 + > block/snapshot.c | 37 +++

Re: [Qemu-devel] [PATCH V9 01/14] block: move bdrv_snapshot_find() to block/snapshot.c

2013-03-11 Thread Wenchao Xia
于 2013-3-12 1:49, Eric Blake 写道: On 03/11/2013 05:23 AM, Wenchao Xia wrote: This patch adds block/snapshot.c and then moves the function there. It also fixes small code style errors reported by check script. Signed-off-by: Wenchao Xia --- block/Makefile.objs |1 + block/snapshot

Re: [Qemu-devel] [PATCH V9 01/14] block: move bdrv_snapshot_find() to block/snapshot.c

2013-03-12 Thread Eric Blake
On 03/11/2013 11:01 PM, Wenchao Xia wrote: > 于 2013-3-12 1:49, Eric Blake 写道: >> On 03/11/2013 05:23 AM, Wenchao Xia wrote: >>>This patch adds block/snapshot.c and then moves the function >>> there. It also fixes small code style errors reported by check script. >>> >>> + * This work is licens

Re: [Qemu-devel] [PATCH V9 01/14] block: move bdrv_snapshot_find() to block/snapshot.c

2013-03-12 Thread Eric Blake
On 03/12/2013 10:15 AM, Eric Blake wrote: > As far as I can tell, there is nothing wrong with leaving the file as > BSD licensed instead of trying to insist that it be LGPL. The block > layer will still be [L]GPL because of other files linked together, but > there is nothing inherently wrong with

Re: [Qemu-devel] [PATCH V9 01/14] block: move bdrv_snapshot_find() to block/snapshot.c

2013-03-12 Thread Wenchao Xia
于 2013-3-13 0:22, Eric Blake 写道: On 03/12/2013 10:15 AM, Eric Blake wrote: As far as I can tell, there is nothing wrong with leaving the file as BSD licensed instead of trying to insist that it be LGPL. The block layer will still be [L]GPL because of other files linked together, but there is no

Re: [Qemu-devel] [PATCH V9 01/14] block: move bdrv_snapshot_find() to block/snapshot.c

2013-03-13 Thread Kevin Wolf
Am 12.03.2013 um 06:01 hat Wenchao Xia geschrieben: > 于 2013-3-12 1:49, Eric Blake 写道: > >On 03/11/2013 05:23 AM, Wenchao Xia wrote: > >> This patch adds block/snapshot.c and then moves the function > >>there. It also fixes small code style errors reported by check script. > >> > >>Signed-off-by:

Re: [Qemu-devel] [PATCH V9 01/14] block: move bdrv_snapshot_find() to block/snapshot.c

2013-03-13 Thread Markus Armbruster
Eric Blake writes: > On 03/11/2013 05:23 AM, Wenchao Xia wrote: >> This patch adds block/snapshot.c and then moves the function >> there. It also fixes small code style errors reported by check script. >> >> Signed-off-by: Wenchao Xia >> --- >> block/Makefile.objs |1 + >> block/sna

Re: [Qemu-devel] [PATCH V9 01/14] block: move bdrv_snapshot_find() to block/snapshot.c

2013-03-13 Thread Markus Armbruster
Kevin Wolf writes: > Am 12.03.2013 um 06:01 hat Wenchao Xia geschrieben: >> Oops, Since it belongs to block layer I hope it can be LGPL2. Do you >> know how to contact Fabrice Bellard to ask for a change? > > Fabrice is not the only copyright owner of this file. > > Just copy the license as it

Re: [Qemu-devel] [PATCH V9 01/14] block: move bdrv_snapshot_find() to block/snapshot.c

2013-03-13 Thread Eric Blake
On 03/13/2013 12:19 PM, Markus Armbruster wrote: > But this isn't relicensing. This is exercising your *right* to > incorporate permissively-licensed stuff into work covered by a > compatible, stronger license. That right was irrevocably granted to you > by the copyright holders. You don't have

Re: [Qemu-devel] [PATCH V9 01/14] block: move bdrv_snapshot_find() to block/snapshot.c

2013-03-14 Thread Kevin Wolf
Am 13.03.2013 um 19:19 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 12.03.2013 um 06:01 hat Wenchao Xia geschrieben: > >> Oops, Since it belongs to block layer I hope it can be LGPL2. Do you > >> know how to contact Fabrice Bellard to ask for a change? > > > > Fabrice is not

Re: [Qemu-devel] [PATCH V9 01/14] block: move bdrv_snapshot_find() to block/snapshot.c

2013-03-14 Thread Markus Armbruster
Kevin Wolf writes: > Am 13.03.2013 um 19:19 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Am 12.03.2013 um 06:01 hat Wenchao Xia geschrieben: >> >> Oops, Since it belongs to block layer I hope it can be LGPL2. Do you >> >> know how to contact Fabrice Bellard to ask for a ch

Re: [Qemu-devel] [PATCH V9 01/14] block: move bdrv_snapshot_find() to block/snapshot.c

2013-03-14 Thread Kevin Wolf
Am 14.03.2013 um 13:10 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > But you have to do it right. This specific patch would introduce a > > copyright violation. It's really not that hard to conform to the terms > > of the MIT license, but that doesn't mean that you can ignore it. The

Re: [Qemu-devel] [PATCH V9 01/14] block: move bdrv_snapshot_find() to block/snapshot.c

2013-03-14 Thread Wenchao Xia
于 2013-3-14 20:53, Kevin Wolf 写道: Am 14.03.2013 um 13:10 hat Markus Armbruster geschrieben: Kevin Wolf writes: But you have to do it right. This specific patch would introduce a copyright violation. It's really not that hard to conform to the terms of the MIT license, but that doesn't mean tha

Re: [Qemu-devel] [PATCH V9 01/14] block: move bdrv_snapshot_find() to block/snapshot.c

2013-03-15 Thread Kevin Wolf
Am 15.03.2013 um 07:23 hat Wenchao Xia geschrieben: > 于 2013-3-14 20:53, Kevin Wolf 写道: > >Am 14.03.2013 um 13:10 hat Markus Armbruster geschrieben: > >>Kevin Wolf writes: > >>>But you have to do it right. This specific patch would introduce a > >>>copyright violation. It's really not that hard to