Re: [Qemu-devel] [PATCH for-2.5 v2 2/4] mips: add Global Config Register block (part)

2016-03-15 Thread Leon Alrae
Hi, I cherry-picked this patch and the other one implementing CP0.Config3.CMGCRBase into my series for the Cluster Power Control needs: https://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg03296.html I think all issues pointed out during the review for these two patches have been addressed

Re: [Qemu-devel] [PATCH for-2.5 v2 2/4] mips: add Global Config Register block (part)

2015-10-30 Thread Peter Maydell
On 30 October 2015 at 11:40, James Hogan wrote: > On Fri, Oct 30, 2015 at 12:36:07AM +, James Hogan wrote: >> Hi Yongbok, >> >> > +case GCR_GIC_BASE_OFS: >> > +return gcr->gic_base; > > Note also, that this is a read-write register. It starts undefined and > the kernel will write t

Re: [Qemu-devel] [PATCH for-2.5 v2 2/4] mips: add Global Config Register block (part)

2015-10-30 Thread James Hogan
On Fri, Oct 30, 2015 at 12:36:07AM +, James Hogan wrote: > Hi Yongbok, > > On Tue, Oct 27, 2015 at 05:12:35PM +, Yongbok Kim wrote: > > Add part of GCR Block which Linux Kernel utilises and it is enough > > to bring the GIC up. > > It defines full 32 Kbytes address space allocated for GCR

Re: [Qemu-devel] [PATCH for-2.5 v2 2/4] mips: add Global Config Register block (part)

2015-10-29 Thread James Hogan
Hi Yongbok, On Tue, Oct 27, 2015 at 05:12:35PM +, Yongbok Kim wrote: > Add part of GCR Block which Linux Kernel utilises and it is enough > to bring the GIC up. > It defines full 32 Kbytes address space allocated for GCR but only few > registers are implemented such as config, revision, status

[Qemu-devel] [PATCH for-2.5 v2 2/4] mips: add Global Config Register block (part)

2015-10-27 Thread Yongbok Kim
Add part of GCR Block which Linux Kernel utilises and it is enough to bring the GIC up. It defines full 32 Kbytes address space allocated for GCR but only few registers are implemented such as config, revision, status, L2 config and local config registers. To support MIPS Coherent Manager, this mod