On Sat, Jun 21, 2014 at 10:59:29PM +0800, Chen Gang wrote:
When failure occurs, 'ret' need be set, or may return 0 to indicate success.
And error_propagate() also need be called only one time within a function.
Signed-off-by: Chen Gang gang.chen.5...@gmail.com
---
block.c | 2 +-
1 file
On 06/23/2014 03:38 PM, Stefan Hajnoczi wrote:
The return value of bdrv_open() is a negative errno. -1 does not make
sense in this case.
Please add an int return value to bdrv_append_temp_snapshot() so the
caller can determine the real errno. Then the remainder of the patch
can be:
When failure occurs, 'ret' need be set, or may return 0 to indicate success.
And error_propagate() also need be called only one time within a function.
Signed-off-by: Chen Gang gang.chen.5...@gmail.com
---
block.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block.c
