Re: [Qemu-devel] [PATCH trivial] main-loop: do not include slirp/slirp.h, use libslirp.h instead

2013-06-12 Thread Paolo Bonzini
Il 12/06/2013 08:36, Michael Tokarev ha scritto: > > Including slirp/slirp.h is somewhat dangerous since it redefines > errno on WIN32, so any file including it may misbehave wrt errno. > > Unfortunately libslirp isn't self-contained, it needs declaration > of struct in_addr, which is provided by

[Qemu-devel] [PATCH trivial] main-loop: do not include slirp/slirp.h, use libslirp.h instead

2013-06-12 Thread Michael Tokarev
The header slirp/slirp.h is an internal header for slirp, and main-loop.c does not use internals from there. Instead, it uses public functions (slirp_update_timeout(), slirp_pollfds_fill() etc) which are declared in qemu/libslirp.h. Including slirp/slirp.h is somewhat dangerous since it redefines