Re: [Qemu-devel] [PATCH v1] hw/s390x: Allow to configure the consoles with the "-serial" parameter

2018-04-25 Thread David Hildenbrand
>>> int ret; >>> @@ -346,6 +355,14 @@ static void ccw_init(MachineState *machine) >>> /* Create VirtIO network adapters */ >>> s390_create_virtio_net(BUS(css_bus), "virtio-net-ccw"); >>> >>> +/* init consoles */ >>> +if (serial_hds[0]) { >>> +

Re: [Qemu-devel] [PATCH v1] hw/s390x: Allow to configure the consoles with the "-serial" parameter

2018-04-25 Thread Peter Maydell
On 25 April 2018 at 11:17, Thomas Huth wrote: > On 25.04.2018 11:50, David Hildenbrand wrote: >> On 25.04.2018 07:21, Thomas Huth wrote: >>> The consoles ("sclpconsole" and "sclplmconsole") can only be configured >>> with "-device" and "-chardev" so far. Other machines use the

Re: [Qemu-devel] [PATCH v1] hw/s390x: Allow to configure the consoles with the "-serial" parameter

2018-04-25 Thread Christian Borntraeger
On 04/25/2018 07:21 AM, Thomas Huth wrote: > The consoles ("sclpconsole" and "sclplmconsole") can only be configured > with "-device" and "-chardev" so far. Other machines use the convenience > option "-serial" to configure the default consoles, even for virtual > consoles like spapr-vty on the

Re: [Qemu-devel] [PATCH v1] hw/s390x: Allow to configure the consoles with the "-serial" parameter

2018-04-25 Thread Thomas Huth
On 25.04.2018 11:50, David Hildenbrand wrote: > On 25.04.2018 07:21, Thomas Huth wrote: >> The consoles ("sclpconsole" and "sclplmconsole") can only be configured >> with "-device" and "-chardev" so far. Other machines use the convenience >> option "-serial" to configure the default consoles, even

Re: [Qemu-devel] [PATCH v1] hw/s390x: Allow to configure the consoles with the "-serial" parameter

2018-04-25 Thread David Hildenbrand
On 25.04.2018 07:21, Thomas Huth wrote: > The consoles ("sclpconsole" and "sclplmconsole") can only be configured > with "-device" and "-chardev" so far. Other machines use the convenience > option "-serial" to configure the default consoles, even for virtual > consoles like spapr-vty on the

[Qemu-devel] [PATCH v1] hw/s390x: Allow to configure the consoles with the "-serial" parameter

2018-04-24 Thread Thomas Huth
The consoles ("sclpconsole" and "sclplmconsole") can only be configured with "-device" and "-chardev" so far. Other machines use the convenience option "-serial" to configure the default consoles, even for virtual consoles like spapr-vty on the pseries machine. So let's support this option on