On 07/04/2012 12:32 AM, Eric Blake wrote:
On 07/03/2012 07:52 AM, Orit Wasserman wrote:
Signed-off-by: Benoit Hudzia benoit.hud...@sap.com
Signed-off-by: Petter Svard pett...@cs.umu.se
Signed-off-by: Aidan Shribman aidan.shrib...@sap.com
Signed-off-by: Orit Wasserman owass...@redhat.com
On 07/04/2012 01:24 AM, Orit Wasserman wrote:
+ret = uleb128_decode_small(src + i, count);
+if (ret 0) {
An nzrun should be a non-zero value; I'd write this as (ret = 0) to
rule out an attempt to pass a zero-length nzrun.
decode can only return -1 (invalid) or the decoded
On 07/04/2012 03:20 AM, Eric Blake wrote:
On 07/03/2012 03:39 PM, Eric Blake wrote:
On 07/03/2012 03:32 PM, Eric Blake wrote:
+ret = uleb128_decode_small(src + i, count);
+if (ret 0) {
An nzrun should be a non-zero value; I'd write this as (ret = 0) to
rule out an attempt
Signed-off-by: Benoit Hudzia benoit.hud...@sap.com
Signed-off-by: Petter Svard pett...@cs.umu.se
Signed-off-by: Aidan Shribman aidan.shrib...@sap.com
Signed-off-by: Orit Wasserman owass...@redhat.com
---
migration.h |4 ++
savevm.c| 172
On 07/03/2012 07:52 AM, Orit Wasserman wrote:
Signed-off-by: Benoit Hudzia benoit.hud...@sap.com
Signed-off-by: Petter Svard pett...@cs.umu.se
Signed-off-by: Aidan Shribman aidan.shrib...@sap.com
Signed-off-by: Orit Wasserman owass...@redhat.com
+int xbzrle_encode_buffer(uint8_t *old_buf,
On 07/03/2012 03:32 PM, Eric Blake wrote:
+ret = uleb128_decode_small(src + i, count);
+if (ret 0) {
An nzrun should be a non-zero value; I'd write this as (ret = 0) to
rule out an attempt to pass a zero-length nzrun.
Correcting myself,
if (ret 0 || !count) {
At this
On 07/03/2012 03:39 PM, Eric Blake wrote:
On 07/03/2012 03:32 PM, Eric Blake wrote:
+ret = uleb128_decode_small(src + i, count);
+if (ret 0) {
An nzrun should be a non-zero value; I'd write this as (ret = 0) to
rule out an attempt to pass a zero-length nzrun.
Correcting
