Re: [Qemu-devel] [PATCH v2] Add .dir-locals.el file to configure emacs coding style

2015-09-15 Thread Michael Tokarev
15.09.2015 19:22, Markus Armbruster wrote: > "Daniel P. Berrange" writes: [] >> Personally I be fine with both the minimal approach or the more >> comprehensive approach of Peter's, but I'd probably tend towards >> the minimal approach to avoid the warnings problem. > > Seconded. > > The "minima

Re: [Qemu-devel] [PATCH v2] Add .dir-locals.el file to configure emacs coding style

2015-09-15 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Tue, Sep 15, 2015 at 09:31:08AM -0600, Eric Blake wrote: >> ping >> >> On 08/24/2015 06:15 PM, John Snow wrote: >> > >> > >> > On 06/18/2015 10:05 AM, Markus Armbruster wrote: >> >> Peter Maydell writes: >> >> >> >>> On 18 June 2015 at 10:28, Markus Armbruste

Re: [Qemu-devel] [PATCH v2] Add .dir-locals.el file to configure emacs coding style

2015-09-15 Thread Daniel P. Berrange
On Tue, Sep 15, 2015 at 09:31:08AM -0600, Eric Blake wrote: > ping > > On 08/24/2015 06:15 PM, John Snow wrote: > > > > > > On 06/18/2015 10:05 AM, Markus Armbruster wrote: > >> Peter Maydell writes: > >> > >>> On 18 June 2015 at 10:28, Markus Armbruster wrote: > However, I can't see how

Re: [Qemu-devel] [PATCH v2] Add .dir-locals.el file to configure emacs coding style

2015-09-15 Thread Eric Blake
ping On 08/24/2015 06:15 PM, John Snow wrote: > > > On 06/18/2015 10:05 AM, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> On 18 June 2015 at 10:28, Markus Armbruster wrote: However, I can't see how I could define a new C style there without pushing the "local variables" fe

Re: [Qemu-devel] [PATCH v2] Add .dir-locals.el file to configure emacs coding style

2015-08-24 Thread John Snow
On 06/18/2015 10:05 AM, Markus Armbruster wrote: > Peter Maydell writes: > >> On 18 June 2015 at 10:28, Markus Armbruster wrote: >>> However, I can't see how I could define a new C style there without >>> pushing the "local variables" feature well beyond its intended use, and >>> triggering th

Re: [Qemu-devel] [PATCH v2] Add .dir-locals.el file to configure emacs coding style

2015-06-18 Thread Markus Armbruster
Peter Maydell writes: > On 18 June 2015 at 10:28, Markus Armbruster wrote: >> However, I can't see how I could define a new C style there without >> pushing the "local variables" feature well beyond its intended use, and >> triggering the confirmation prompts. > > We wouldn't want to define a ne

Re: [Qemu-devel] [PATCH v2] Add .dir-locals.el file to configure emacs coding style

2015-06-18 Thread Peter Maydell
On 18 June 2015 at 10:28, Markus Armbruster wrote: > However, I can't see how I could define a new C style there without > pushing the "local variables" feature well beyond its intended use, and > triggering the confirmation prompts. We wouldn't want to define a new C style, but in general the it

Re: [Qemu-devel] [PATCH v2] Add .dir-locals.el file to configure emacs coding style

2015-06-18 Thread Markus Armbruster
Peter Maydell writes: > On 4 June 2015 at 14:30, Daniel P. Berrange wrote: >> Some default emacs setups indent by 2 spaces and uses tabs >> which is counter to the QEMU coding style rules. Adding a >> .dir-locals.el file in the top level of the GIT repo will >> inform emacs about the QEMU coding

Re: [Qemu-devel] [PATCH v2] Add .dir-locals.el file to configure emacs coding style

2015-06-04 Thread Daniel P. Berrange
On Thu, Jun 04, 2015 at 02:41:42PM +0100, Peter Maydell wrote: > On 4 June 2015 at 14:30, Daniel P. Berrange wrote: > > Some default emacs setups indent by 2 spaces and uses tabs > > which is counter to the QEMU coding style rules. Adding a > > .dir-locals.el file in the top level of the GIT repo

Re: [Qemu-devel] [PATCH v2] Add .dir-locals.el file to configure emacs coding style

2015-06-04 Thread Peter Maydell
On 4 June 2015 at 14:30, Daniel P. Berrange wrote: > Some default emacs setups indent by 2 spaces and uses tabs > which is counter to the QEMU coding style rules. Adding a > .dir-locals.el file in the top level of the GIT repo will > inform emacs about the QEMU coding style, and so assist > contri

[Qemu-devel] [PATCH v2] Add .dir-locals.el file to configure emacs coding style

2015-06-04 Thread Daniel P. Berrange
Some default emacs setups indent by 2 spaces and uses tabs which is counter to the QEMU coding style rules. Adding a .dir-locals.el file in the top level of the GIT repo will inform emacs about the QEMU coding style, and so assist contributors in avoiding common style mistakes before they submit pa