Re: [Qemu-devel] [PATCH v2] Use macro instead of plain text

On 12/18/2015 08:52 PM, Markus Armbruster wrote: Cao jin writes: There is TYPE_ICH9_AHCI definition in ahci.h when QOMify it, seems it is missed. Signed-off-by: Cao jin --- hw/i386/pc_q35.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Qemu-devel] [PATCH v2] Use macro instead of plain text

Hi Peter, Thanks for the explanation, it make me aware that why there are lots of "plain_text_for_device":) forget it please. On 12/18/2015 09:01 PM, Peter Maydell wrote: On 18 December 2015 at 12:52, Markus Armbruster wrote: Cao jin writes:

[Qemu-devel] [PATCH v2] Use macro instead of plain text

There is TYPE_ICH9_AHCI definition in ahci.h when QOMify it, seems it is missed. Signed-off-by: Cao jin --- hw/i386/pc_q35.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index 9a12068..aa34a07 100644 ---

Re: [Qemu-devel] [PATCH v2] Use macro instead of plain text

Cao jin writes: > There is TYPE_ICH9_AHCI definition in ahci.h when QOMify it, seems it > is missed. > > Signed-off-by: Cao jin > --- > hw/i386/pc_q35.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/i386/pc_q35.c

Re: [Qemu-devel] [PATCH v2] Use macro instead of plain text

On 18 December 2015 at 12:52, Markus Armbruster wrote: > Cao jin writes: > >> There is TYPE_ICH9_AHCI definition in ahci.h when QOMify it, seems it >> is missed. > I suspect there are more instances of the same problem. > Not sure how interested we