On 15/10/2017 19:53, Stefan Weil wrote:
>> I see your arguments. Maybe that part can be removed from my patch
>> when it is applied, or should I send a v3 (cc'ing qemu-trivial)?
Sending v3 to trivial makes sense.
> While thinking more about that line of code, I wonder whether
> it would make
Am 15.10.2017 um 19:46 schrieb Stefan Weil:
> Am 15.10.2017 um 17:32 schrieb Paolo Bonzini:
>> On 14/10/2017 18:53, Philippe Mathieu-Daudé wrote:
@@ -328,7 +328,7 @@ static void *do_touch_pages(void *arg)
* don't need to write at all so we don't cause
*
Am 15.10.2017 um 17:32 schrieb Paolo Bonzini:
> On 14/10/2017 18:53, Philippe Mathieu-Daudé wrote:
>>> @@ -328,7 +328,7 @@ static void *do_touch_pages(void *arg)
>>> * don't need to write at all so we don't cause
>>> * wear on the storage backing the region...
>>>
On 14/10/2017 18:53, Philippe Mathieu-Daudé wrote:
>> @@ -328,7 +328,7 @@ static void *do_touch_pages(void *arg)
>> * don't need to write at all so we don't cause
>> * wear on the storage backing the region...
>> */
>> -*(volatile char *)addr =
Hi Stefan,
On 10/13/2017 02:48 AM, Stefan Weil wrote:
> diff --git a/util/oslib-posix.c b/util/oslib-posix.c
> index 80086c549f..beef148c96 100644
> --- a/util/oslib-posix.c
> +++ b/util/oslib-posix.c
> @@ -59,8 +59,8 @@
>
> struct MemsetThread {
> char *addr;
> -uint64_t numpages;
>
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20171013054842.32120-1...@weilnetz.de
Subject: [Qemu-devel] [PATCH v2] oslib-posix: Fix compiler warning and some
data types
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE
gcc warning:
/qemu/util/oslib-posix.c:304:11: error:
variable ‘addr’ might be clobbered by ‘longjmp’ or ‘vfork’
[-Werror=clobbered]
Fix also some related data types:
numpages, hpagesize are used as pointer offset.
Always use size_t for them and for the derived numpages_per_thread.
Avoid a
