Re: [Qemu-devel] [PATCH v2] stop using stdio for monitor/serial/etc with -daemonize

2012-10-27 Thread Michael Tokarev
On 26.09.2012 18:56, Michael Tokarev wrote: On 26.09.2012 17:46, Anthony Liguori wrote: [] This is a good example of where we need improved documentation but I agree 100% with Peter. So what do we do? We've a clear bug, I can only fix it in the patch to the Debian package, since I've

Re: [Qemu-devel] [PATCH v2] stop using stdio for monitor/serial/etc with -daemonize

2012-10-27 Thread Peter Maydell
On 27 October 2012 12:23, Michael Tokarev m...@tls.msk.ru wrote: I still don't see why -nographic -daemonize makes no sence while -curses -daemonize does? My vote is that neither of these combinations makes sense. -- PMM

Re: [Qemu-devel] [PATCH v2] stop using stdio for monitor/serial/etc with -daemonize

2012-10-27 Thread Michael Tokarev
On 27.10.2012 15:33, Peter Maydell wrote: On 27 October 2012 12:23, Michael Tokarev m...@tls.msk.ru wrote: I still don't see why -nographic -daemonize makes no sence while -curses -daemonize does? My vote is that neither of these combinations makes sense. I agree. Well, almost --

Re: [Qemu-devel] [PATCH v2] stop using stdio for monitor/serial/etc with -daemonize

2012-10-27 Thread Blue Swirl
On Sat, Oct 27, 2012 at 12:15 PM, Michael Tokarev m...@tls.msk.ru wrote: On 27.10.2012 15:33, Peter Maydell wrote: On 27 October 2012 12:23, Michael Tokarev m...@tls.msk.ru wrote: I still don't see why -nographic -daemonize makes no sence while -curses -daemonize does? My vote is

Re: [Qemu-devel] [PATCH v2] stop using stdio for monitor/serial/etc with -daemonize

2012-10-27 Thread Michael Tokarev
On 27.10.2012 16:48, Blue Swirl wrote: [] I'd rather have -nographic work with -daemonize, since the alternative - shown in the patch comment - is rather long and it is easy to forget to nullify some option, while -nographic can do that easy and it is convinient, but if people dislikes such

Re: [Qemu-devel] [PATCH v2] stop using stdio for monitor/serial/etc with -daemonize

2012-10-27 Thread Michael Tokarev
On 27.10.2012 16:55, Michael Tokarev wrote: On 27.10.2012 16:48, Blue Swirl wrote: [] I'd rather have -nographic work with -daemonize, since the alternative - shown in the patch comment - is rather long and it is easy to forget to nullify some option, while -nographic can do that easy and it

Re: [Qemu-devel] [PATCH v2] stop using stdio for monitor/serial/etc with -daemonize

2012-09-26 Thread Michael Tokarev
On 26.09.2012 01:19, Anthony Liguori wrote: Combining -nographic and -daemonize don't make sense. I'd rather error out with this combination. I think what the user is after is -daemonize -vga none OR -daemonize -display none. So what's the difference? I know lots of people use -nographic

Re: [Qemu-devel] [PATCH v2] stop using stdio for monitor/serial/etc with -daemonize

2012-09-26 Thread Peter Maydell
On 26 September 2012 08:09, Michael Tokarev m...@tls.msk.ru wrote: On 26.09.2012 01:19, Anthony Liguori wrote: Combining -nographic and -daemonize don't make sense. I'd rather error out with this combination. I think what the user is after is -daemonize -vga none OR -daemonize -display

Re: [Qemu-devel] [PATCH v2] stop using stdio for monitor/serial/etc with -daemonize

2012-09-26 Thread Michael Tokarev
On 26.09.2012 12:00, Peter Maydell wrote: I know lots of people use -nographic -daemonize to run headless guests in background (like, for example, a router). I guess it come way before -vga option has been introduced, but at least I know about -vga (but not about -vga none). For one, I

Re: [Qemu-devel] [PATCH v2] stop using stdio for monitor/serial/etc with -daemonize

2012-09-26 Thread Peter Maydell
On 26 September 2012 09:17, Michael Tokarev m...@tls.msk.ru wrote: On 26.09.2012 12:00, Peter Maydell wrote: I know lots of people use -nographic -daemonize to run headless guests in background (like, for example, a router). I guess it come way before -vga option has been introduced, but at

Re: [Qemu-devel] [PATCH v2] stop using stdio for monitor/serial/etc with -daemonize

2012-09-26 Thread Anthony Liguori
Peter Maydell peter.mayd...@linaro.org writes: On 26 September 2012 09:17, Michael Tokarev m...@tls.msk.ru wrote: On 26.09.2012 12:00, Peter Maydell wrote: I know lots of people use -nographic -daemonize to run headless guests in background (like, for example, a router). I guess it come

Re: [Qemu-devel] [PATCH v2] stop using stdio for monitor/serial/etc with -daemonize

2012-09-26 Thread Michael Tokarev
On 26.09.2012 17:46, Anthony Liguori wrote: [] This is a good example of where we need improved documentation but I agree 100% with Peter. So what do we do? We've a clear bug, I can only fix it in the patch to the Debian package, since I've been asked about this bug multiple times, and I care

[Qemu-devel] [PATCH v2] stop using stdio for monitor/serial/etc with -daemonize

2012-09-25 Thread Michael Tokarev
Current code binds monitor and serial port to the guest console unless -nographic is specified, which is okay. But when there's no guest console (-nographic), the code tries to use stdio for the same default devices. But it does not check for -daemonize at the same time -- because when

Re: [Qemu-devel] [PATCH v2] stop using stdio for monitor/serial/etc with -daemonize

2012-09-25 Thread Anthony Liguori
Michael Tokarev m...@tls.msk.ru writes: Current code binds monitor and serial port to the guest console unless -nographic is specified, which is okay. But when there's no guest console (-nographic), the code tries to use stdio for the same default devices. But it does not check for