Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-09 Thread Gerd Hoffmann
Hi, > > We can and should say no. Sometimes we can also say yes though. :) > > > > I just think that Braille is worth a special case because a subset of > > our user base (blind people) will use it 100% of the time, plus it is > > not supported by libvirt and hence virt-manager. > > OK, then

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-09 Thread Thomas Huth
On 09.01.2018 12:17, Paolo Bonzini wrote: > On 09/01/2018 12:00, Thomas Huth wrote: >> On 09.01.2018 10:58, Paolo Bonzini wrote: >>> On 08/01/2018 08:23, Thomas Huth wrote: >> But instead of introducing a new "-braille" parameter, maybe we should >> rather keep some of the convenience "-usb

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-09 Thread Paolo Bonzini
On 09/01/2018 12:00, Thomas Huth wrote: > On 09.01.2018 10:58, Paolo Bonzini wrote: >> On 08/01/2018 08:23, Thomas Huth wrote: > But instead of introducing a new "-braille" parameter, maybe we should > rather keep some of the convenience "-usbdevice" possibilities around? > E.g. keep "-

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-09 Thread Thomas Huth
On 09.01.2018 10:58, Paolo Bonzini wrote: > On 08/01/2018 08:23, Thomas Huth wrote: But instead of introducing a new "-braille" parameter, maybe we should rather keep some of the convenience "-usbdevice" possibilities around? E.g. keep "-usbdevice braille", "-usbdevice mouse", etc. b

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-09 Thread Paolo Bonzini
On 08/01/2018 08:23, Thomas Huth wrote: >>> But instead of introducing a new "-braille" parameter, maybe we should >>> rather keep some of the convenience "-usbdevice" possibilities around? >>> E.g. keep "-usbdevice braille", "-usbdevice mouse", etc. but remove >>> things like "-usbdevice serial" a

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-09 Thread Paolo Bonzini
On 08/01/2018 08:43, Thomas Huth wrote: > On 04.01.2018 18:57, Paolo Bonzini wrote: >> On 04/01/2018 18:45, Samuel Thibault wrote: >>> Paolo Bonzini, on jeu. 04 janv. 2018 18:11:00 +0100, wrote: On 04/01/2018 16:56, Samuel Thibault wrote: >> However, adding magic to "-device usb-braille" t

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-07 Thread Thomas Huth
On 04.01.2018 18:57, Paolo Bonzini wrote: > On 04/01/2018 18:45, Samuel Thibault wrote: >> Paolo Bonzini, on jeu. 04 janv. 2018 18:11:00 +0100, wrote: >>> On 04/01/2018 16:56, Samuel Thibault wrote: > However, adding magic to "-device usb-braille" that creates both a > front-end and a back-

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-07 Thread Thomas Huth
On 04.01.2018 18:10, Paolo Bonzini wrote: > On 04/01/2018 16:59, Thomas Huth wrote: >> >> But instead of introducing a new "-braille" parameter, maybe we should >> rather keep some of the convenience "-usbdevice" possibilities around? >> E.g. keep "-usbdevice braille", "-usbdevice mouse", etc. but

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-05 Thread Markus Armbruster
Paolo Bonzini writes: > On 05/01/2018 09:18, Markus Armbruster wrote: Would it be possible to make this automatic? Before I could tell people "use -usbdevice braille to test braille", and now it would be "use -chardev braille,chardev=foobar -device usb-braille,chardev=foobar" >>>

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-05 Thread Paolo Bonzini
On 05/01/2018 09:18, Markus Armbruster wrote: >>> Would it be possible to make this automatic? Before I could tell people >>> "use -usbdevice braille to test braille", and now it would be >>> "use -chardev braille,chardev=foobar -device usb-braille,chardev=foobar" >> Maybe we can add "-braille" in

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-05 Thread Markus Armbruster
Peter Maydell writes: > On 4 January 2018 at 15:47, Paolo Bonzini wrote: >> The point of deprecation is not to make the interface simpler, it is to >> avoid cases where one option is doing too much and/or crossing >> abstraction boundaries, for example -net creating both a device and a >> hub po

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-05 Thread Markus Armbruster
Paolo Bonzini writes: > On 04/01/2018 15:21, Samuel Thibault wrote: >> Samuel Thibault, on jeu. 04 janv. 2018 15:15:24 +0100, wrote: >>> I'm however still unable to make usb-serial and usb-braille work, as >>> mentioned in my other mail :) >> >> Ah, now with the documentation I understand, one h

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-04 Thread Samuel Thibault
Paolo Bonzini, on jeu. 04 janv. 2018 18:57:18 +0100, wrote: > On 04/01/2018 18:45, Samuel Thibault wrote: > > Paolo Bonzini, on jeu. 04 janv. 2018 18:11:00 +0100, wrote: > >> On 04/01/2018 16:56, Samuel Thibault wrote: > However, adding magic to "-device usb-braille" that creates both a >

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-04 Thread Paolo Bonzini
On 04/01/2018 18:45, Samuel Thibault wrote: > Paolo Bonzini, on jeu. 04 janv. 2018 18:11:00 +0100, wrote: >> On 04/01/2018 16:56, Samuel Thibault wrote: However, adding magic to "-device usb-braille" that creates both a front-end and a back-end is completely the opposite of sane... >>> We

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-04 Thread Samuel Thibault
Paolo Bonzini, on jeu. 04 janv. 2018 18:11:00 +0100, wrote: > On 04/01/2018 16:56, Samuel Thibault wrote: > >> However, adding magic to "-device usb-braille" that creates both a > >> front-end and a back-end is completely the opposite of sane... > > Well, this is also what happens with -device usb-

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-04 Thread Paolo Bonzini
On 04/01/2018 16:59, Thomas Huth wrote: > > But instead of introducing a new "-braille" parameter, maybe we should > rather keep some of the convenience "-usbdevice" possibilities around? > E.g. keep "-usbdevice braille", "-usbdevice mouse", etc. but remove > things like "-usbdevice serial" and "-

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-04 Thread Paolo Bonzini
On 04/01/2018 16:56, Samuel Thibault wrote: >> However, adding magic to "-device usb-braille" that creates both a >> front-end and a back-end is completely the opposite of sane... > Well, this is also what happens with -device usb-mouse, usb-kbd etc.: > they also plug with keyboard & mouse pipes of

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-04 Thread Thomas Huth
On 04.01.2018 16:47, Paolo Bonzini wrote: > On 04/01/2018 16:35, Thomas Huth wrote: >>> Well, why not, it just doesn't seem to me much simpler than >>> "-serial braille" and "-device usb-braille" :) >> >> FWIW, I think I'd also rather prefer to add some little bit of "magic" >> to "-device usb-brai

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-04 Thread Samuel Thibault
Paolo Bonzini, on jeu. 04 janv. 2018 16:47:16 +0100, wrote: > The point of deprecation is not to make the interface simpler, it is to > avoid cases where one option is doing too much and/or crossing > abstraction boundaries, for example -net creating both a device and a > hub port. > > "-serial" i

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-04 Thread Peter Maydell
On 4 January 2018 at 15:47, Paolo Bonzini wrote: > The point of deprecation is not to make the interface simpler, it is to > avoid cases where one option is doing too much and/or crossing > abstraction boundaries, for example -net creating both a device and a > hub port. > > "-serial" is okay beca

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-04 Thread Paolo Bonzini
On 04/01/2018 16:35, Thomas Huth wrote: >> Well, why not, it just doesn't seem to me much simpler than >> "-serial braille" and "-device usb-braille" :) > > FWIW, I think I'd also rather prefer to add some little bit of "magic" > to "-device usb-braille" instead of introducing yet another command l

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-04 Thread Thomas Huth
On 04.01.2018 16:28, Paolo Bonzini wrote: > On 04/01/2018 16:24, Samuel Thibault wrote: >>> Maybe we can add "-braille" instead. >> I guess such legacy-looking option would be frowned up :) > > Not really. As long as it doesn't propagate everywhere in device code, > it's fine. We are not going t

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-04 Thread Thomas Huth
On 04.01.2018 16:32, Samuel Thibault wrote: > Paolo Bonzini, on jeu. 04 janv. 2018 16:28:27 +0100, wrote: >> On 04/01/2018 16:24, Samuel Thibault wrote: Maybe we can add "-braille" instead. >>> I guess such legacy-looking option would be frowned up :) >> >> Not really. As long as it doesn't p

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-04 Thread Paolo Bonzini
On 04/01/2018 16:32, Samuel Thibault wrote: >>> And anyway we need to be able to specify either -serial braille or >>> -device usb-braille. >> So "-braille serial" and "-braille usb"? > Well, why not, it just doesn't seem to me much simpler than > "-serial braille" and "-device usb-braille" :) The

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-04 Thread Samuel Thibault
Paolo Bonzini, on jeu. 04 janv. 2018 16:28:27 +0100, wrote: > On 04/01/2018 16:24, Samuel Thibault wrote: > >> Maybe we can add "-braille" instead. > > I guess such legacy-looking option would be frowned up :) > > Not really. As long as it doesn't propagate everywhere in device code, > it's fine.

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-04 Thread Paolo Bonzini
On 04/01/2018 16:24, Samuel Thibault wrote: >> Maybe we can add "-braille" instead. > I guess such legacy-looking option would be frowned up :) Not really. As long as it doesn't propagate everywhere in device code, it's fine. We are not going to deprecate "-serial mon:stdio", so... > And anyway

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-04 Thread Samuel Thibault
Hello, Paolo Bonzini, on jeu. 04 janv. 2018 16:19:02 +0100, wrote: > On 04/01/2018 15:21, Samuel Thibault wrote: > > Samuel Thibault, on jeu. 04 janv. 2018 15:15:24 +0100, wrote: > >> I'm however still unable to make usb-serial and usb-braille work, as > >> mentioned in my other mail :) > > > > A

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-04 Thread Paolo Bonzini
On 04/01/2018 15:21, Samuel Thibault wrote: > Samuel Thibault, on jeu. 04 janv. 2018 15:15:24 +0100, wrote: >> I'm however still unable to make usb-serial and usb-braille work, as >> mentioned in my other mail :) > > Ah, now with the documentation I understand, one has to also pass > -chardev brai

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-04 Thread Samuel Thibault
Samuel Thibault, on jeu. 04 janv. 2018 15:15:24 +0100, wrote: > I'm however still unable to make usb-serial and usb-braille work, as > mentioned in my other mail :) Ah, now with the documentation I understand, one has to also pass -chardev braille,chardev=foobar, and then -device usb-braille,chard

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-04 Thread Samuel Thibault
Thomas Huth, on jeu. 04 janv. 2018 15:12:56 +0100, wrote: > On 04.01.2018 15:09, Samuel Thibault wrote: > > Thomas Huth, on jeu. 04 janv. 2018 14:15:52 +0100, wrote: > >> -@item host:@var{bus}.@var{addr} > >> -Pass through the host device identified by @var{bus}.@var{addr} (Linux > >> only). > >>

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-04 Thread Thomas Huth
On 04.01.2018 15:09, Samuel Thibault wrote: > Thomas Huth, on jeu. 04 janv. 2018 14:15:52 +0100, wrote: >> -@item host:@var{bus}.@var{addr} >> -Pass through the host device identified by @var{bus}.@var{addr} (Linux >> only). >> - >> -@item host:@var{vendor_id}:@var{product_id} >> -Pass through the

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-04 Thread Samuel Thibault
Thomas Huth, on jeu. 04 janv. 2018 14:15:52 +0100, wrote: > -@item host:@var{bus}.@var{addr} > -Pass through the host device identified by @var{bus}.@var{addr} (Linux only). > - > -@item host:@var{vendor_id}:@var{product_id} > -Pass through the host device identified by @var{vendor_id}:@var{product

[Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-04 Thread Thomas Huth
The option has been marked as deprecated since QEMU 2.10, and so far nobody complained that it is urgently required anymore. So let's now get rid of this legacy pile, to simplify the usb code quite a bit. Signed-off-by: Thomas Huth --- v2: Keep a stub in vl.c that still prints out an error messa