Re: [Qemu-devel] [PATCH v2] vhost-user: pass message as a pointer to process_message_reply()

2017-05-25 Thread Michael S. Tsirkin
On Thu, May 25, 2017 at 05:57:43PM +0200, Maxime Coquelin wrote: > > > On 05/24/2017 11:58 PM, Michael S. Tsirkin wrote: > > On Wed, May 24, 2017 at 11:05:20AM +0200, Maxime Coquelin wrote: > > > process_message_reply() was recently updated to get full message > > > content instead of only its re

Re: [Qemu-devel] [PATCH v2] vhost-user: pass message as a pointer to process_message_reply()

2017-05-25 Thread Maxime Coquelin
On 05/24/2017 11:58 PM, Michael S. Tsirkin wrote: On Wed, May 24, 2017 at 11:05:20AM +0200, Maxime Coquelin wrote: process_message_reply() was recently updated to get full message content instead of only its request field. There is no need to copy all the struct content into the stack, so jus

Re: [Qemu-devel] [PATCH v2] vhost-user: pass message as a pointer to process_message_reply()

2017-05-24 Thread Michael S. Tsirkin
On Wed, May 24, 2017 at 11:05:20AM +0200, Maxime Coquelin wrote: > process_message_reply() was recently updated to get full message > content instead of only its request field. > > There is no need to copy all the struct content into the stack, > so just pass its pointer as const. > > Cc: Zhiyong

Re: [Qemu-devel] [PATCH v2] vhost-user: pass message as a pointer to process_message_reply()

2017-05-24 Thread Marc-André Lureau
Hi On Wed, May 24, 2017 at 1:06 PM Maxime Coquelin wrote: > process_message_reply() was recently updated to get full message > content instead of only its request field. > > There is no need to copy all the struct content into the stack, > so just pass its pointer as const. > > Cc: Zhiyong Yang

[Qemu-devel] [PATCH v2] vhost-user: pass message as a pointer to process_message_reply()

2017-05-24 Thread Maxime Coquelin
process_message_reply() was recently updated to get full message content instead of only its request field. There is no need to copy all the struct content into the stack, so just pass its pointer as const. Cc: Zhiyong Yang Fixes: 60cd11024f41 ("hw/virtio: fix vhost user fails to startup when MQ