Re: [Qemu-devel] [PATCH v2] vnc: Fix packed boolean struct members

2012-03-15 Thread Stefan Hajnoczi
On Thu, Mar 08, 2012 at 10:58:06PM +0100, Stefan Weil wrote: > This patch fixes warnings reported by splint: > > For variables which are packed in a single bit, a signed data type > like 'int' does not make much sense. > > There is no obvious reason why the two values should be packed, > so I rem

[Qemu-devel] [PATCH v2] vnc: Fix packed boolean struct members

2012-03-08 Thread Stefan Weil
This patch fixes warnings reported by splint: For variables which are packed in a single bit, a signed data type like 'int' does not make much sense. There is no obvious reason why the two values should be packed, so I removed the packing and changed the data type to bool because both are used as