Re: [Qemu-devel] [PATCH v2 00/19] usb: convert device init to realize

2014-09-19 Thread Markus Armbruster
Paolo Bonzini writes: > Il 18/09/2014 19:15, Markus Armbruster ha scritto: >> >> Thanks for doing this work. If you can do a bit more of the same, here >> are a few more device model init() methods I'd love to have converted, >> because they use qerror_report_err(): >> >> hw/char/serial-pci.c

Re: [Qemu-devel] [PATCH v2 00/19] usb: convert device init to realize

2014-09-18 Thread Gonglei (Arei)
> From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Friday, September 19, 2014 2:06 PM > To: Gonglei (Arei) > Subject: Re: [PATCH v2 00/19] usb: convert device init to realize > > On Do, 2014-09-18 at 20:47 +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > DeviceClass->init is

Re: [Qemu-devel] [PATCH v2 00/19] usb: convert device init to realize

2014-09-18 Thread Gerd Hoffmann
On Do, 2014-09-18 at 20:47 +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > DeviceClass->init is the old interface, let's convert usb > devices to the new realize API. In this way, all the > implementations now use error_setg instead of > qerror_report/error_report for reporting error.

Re: [Qemu-devel] [PATCH v2 00/19] usb: convert device init to realize

2014-09-18 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Friday, September 19, 2014 2:42 AM > Subject: Re: [PATCH v2 00/19] usb: convert device init to realize > > Il 18/09/2014 19:15, Markus Armbruster ha scritto: > > > > Thanks for doing this work. If you can

Re: [Qemu-devel] [PATCH v2 00/19] usb: convert device init to realize

2014-09-18 Thread Paolo Bonzini
Il 18/09/2014 19:15, Markus Armbruster ha scritto: > > Thanks for doing this work. If you can do a bit more of the same, here > are a few more device model init() methods I'd love to have converted, > because they use qerror_report_err(): > > hw/char/serial-pci.cserial_pci_init() >

Re: [Qemu-devel] [PATCH v2 00/19] usb: convert device init to realize

2014-09-18 Thread Markus Armbruster
writes: > From: Gonglei > > DeviceClass->init is the old interface, let's convert usb > devices to the new realize API. In this way, all the > implementations now use error_setg instead of > qerror_report/error_report for reporting error. [...] Thanks for doing this work. If you can do a bit

Re: [Qemu-devel] [PATCH v2 00/19] usb: convert device init to realize

2014-09-18 Thread Paolo Bonzini
Il 18/09/2014 14:47, arei.gong...@huawei.com ha scritto: > From: Gonglei > > DeviceClass->init is the old interface, let's convert usb > devices to the new realize API. In this way, all the > implementations now use error_setg instead of > qerror_report/error_report for reporting error. > > Cc:

[Qemu-devel] [PATCH v2 00/19] usb: convert device init to realize

2014-09-18 Thread arei.gonglei
From: Gonglei DeviceClass->init is the old interface, let's convert usb devices to the new realize API. In this way, all the implementations now use error_setg instead of qerror_report/error_report for reporting error. Cc: Markus Armbruster Cc: Paolo Bonzini Cc: Gerd Hoffmann v2 -> v1: - f