Re: [Qemu-devel] [PATCH v2 05/67] target/arm: Implement SVE load vector/predicate

2018-04-06 Thread Alex Bennée
Richard Henderson writes: > On 04/03/2018 07:26 PM, Alex Bennée wrote: >> You don't use it yet but probably worth a: >> >> static inline int ffr_full_reg_offset(DisasContext *s) >> { >> return pred_full_reg_offset(s, 16); >> } >> >> here when you get to it to avoid the magic 16 appearing in

Re: [Qemu-devel] [PATCH v2 05/67] target/arm: Implement SVE load vector/predicate

2018-04-05 Thread Richard Henderson
On 04/03/2018 07:26 PM, Alex Bennée wrote: > You don't use it yet but probably worth a: > > static inline int ffr_full_reg_offset(DisasContext *s) > { > return pred_full_reg_offset(s, 16); > } > > here when you get to it to avoid the magic 16 appearing in the main code. Hum. Most of the pla

Re: [Qemu-devel] [PATCH v2 05/67] target/arm: Implement SVE load vector/predicate

2018-04-03 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson > --- > target/arm/translate-sve.c | 132 > + > target/arm/sve.decode | 22 +++- > 2 files changed, 153 insertions(+), 1 deletion(-) > > diff --git a/target/arm/translate-sve.c b

Re: [Qemu-devel] [PATCH v2 05/67] target/arm: Implement SVE load vector/predicate

2018-02-22 Thread Richard Henderson
On 02/22/2018 10:20 AM, Peter Maydell wrote: > On 17 February 2018 at 18:22, Richard Henderson > wrote: >> Signed-off-by: Richard Henderson >> --- >> target/arm/translate-sve.c | 132 >> + >> target/arm/sve.decode | 22 +++- >> 2 files chang

Re: [Qemu-devel] [PATCH v2 05/67] target/arm: Implement SVE load vector/predicate

2018-02-22 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/translate-sve.c | 132 > + > target/arm/sve.decode | 22 +++- > 2 files changed, 153 insertions(+), 1 deletion(-) > > diff --git a/t

[Qemu-devel] [PATCH v2 05/67] target/arm: Implement SVE load vector/predicate

2018-02-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate-sve.c | 132 + target/arm/sve.decode | 22 +++- 2 files changed, 153 insertions(+), 1 deletion(-) diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index 50cf2a1fdd.