Re: [Qemu-devel] [PATCH v2 08/22] nbd/client: Drop pointless buf variable

2019-01-05 Thread Eric Blake
On 12/15/18 7:53 AM, Eric Blake wrote: > There's no need to read into a temporary buffer (oversized > since commit 7d3123e1) followed by a byteswap into a uint64_t > to check for a magic number via memcmp(), when the code > immediately below demonstrates reading into the uint64_t then > byteswappin

[Qemu-devel] [PATCH v2 08/22] nbd/client: Drop pointless buf variable

2018-12-15 Thread Eric Blake
There's no need to read into a temporary buffer (oversized since commit 7d3123e1) followed by a byteswap into a uint64_t to check for a magic number via memcmp(), when the code immediately below demonstrates reading into the uint64_t then byteswapping in place and checking for a magic number via in