Re: [Qemu-devel] [PATCH v2 11/19] s390x: allow only 1 CPU with TCG

2017-09-15 Thread Cornelia Huck
On Thu, 14 Sep 2017 20:13:49 +0200 David Hildenbrand wrote: > FWIW, I started factoring out today KVM SIGP code to make it usable by TCG. > > I also started adding the missing SIGP instructions the kernel handles > for KVM. I dropped the old TCG SIGP handling code and

Re: [Qemu-devel] [PATCH v2 11/19] s390x: allow only 1 CPU with TCG

2017-09-14 Thread David Hildenbrand
On 06.09.2017 23:20, Richard Henderson wrote: > On 09/06/2017 11:16 AM, Matthew Rosato wrote: >> On 09/04/2017 11:43 AM, David Hildenbrand wrote: >>> Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the >>> guest tries to bring these CPUs up but fails), because we don't support >>>

Re: [Qemu-devel] [PATCH v2 11/19] s390x: allow only 1 CPU with TCG

2017-09-07 Thread Cornelia Huck
On Thu, 7 Sep 2017 14:49:49 +0200 David Hildenbrand wrote: > On 06.09.2017 23:20, Richard Henderson wrote: > > On 09/06/2017 11:16 AM, Matthew Rosato wrote: > >> On 09/04/2017 11:43 AM, David Hildenbrand wrote: > >>> Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP

Re: [Qemu-devel] [PATCH v2 11/19] s390x: allow only 1 CPU with TCG

2017-09-07 Thread David Hildenbrand
On 06.09.2017 23:20, Richard Henderson wrote: > On 09/06/2017 11:16 AM, Matthew Rosato wrote: >> On 09/04/2017 11:43 AM, David Hildenbrand wrote: >>> Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the >>> guest tries to bring these CPUs up but fails), because we don't support >>>

Re: [Qemu-devel] [PATCH v2 11/19] s390x: allow only 1 CPU with TCG

2017-09-06 Thread Richard Henderson
On 09/06/2017 11:16 AM, Matthew Rosato wrote: > On 09/04/2017 11:43 AM, David Hildenbrand wrote: >> Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the >> guest tries to bring these CPUs up but fails), because we don't support >> multiple CPUs on s390x under TCG. >> >> Let's bail

Re: [Qemu-devel] [PATCH v2 11/19] s390x: allow only 1 CPU with TCG

2017-09-06 Thread Matthew Rosato
On 09/04/2017 11:43 AM, David Hildenbrand wrote: > Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the > guest tries to bring these CPUs up but fails), because we don't support > multiple CPUs on s390x under TCG. > > Let's bail out if more than 1 is specified, so we don't raise

[Qemu-devel] [PATCH v2 11/19] s390x: allow only 1 CPU with TCG

2017-09-04 Thread David Hildenbrand
Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the guest tries to bring these CPUs up but fails), because we don't support multiple CPUs on s390x under TCG. Let's bail out if more than 1 is specified, so we don't raise people's hope. Make it a define, so we can easily bump it up