Re: [Qemu-devel] [PATCH v2 2/5] musicpal: qdevify musicpal-misc

2013-03-04 Thread Peter Maydell
On 4 March 2013 19:22, Andreas Färber wrote: > Am 25.02.2013 18:08, schrieb Peter Maydell: >> --- a/hw/musicpal.c >> +++ b/hw/musicpal.c >> @@ -1031,6 +1031,15 @@ static const TypeInfo mv88w8618_flashcfg_info = { >> >> #define MP_BOARD_REVISION 0x31 >> >> +typedef struct { >> +SysBusDev

Re: [Qemu-devel] [PATCH v2 2/5] musicpal: qdevify musicpal-misc

2013-03-04 Thread Andreas Färber
Am 25.02.2013 18:08, schrieb Peter Maydell: > Make musicpal-misc into its own (trivial) qdev device, so we > can get rid of the abuse of sysbus_add_memory(). > > Signed-off-by: Peter Maydell > --- > hw/musicpal.c | 28 +++- > 1 file changed, 23 insertions(+), 5 deletion

Re: [Qemu-devel] [PATCH v2 2/5] musicpal: qdevify musicpal-misc

2013-03-03 Thread Peter Crosthwaite
On Tue, Feb 26, 2013 at 3:08 AM, Peter Maydell wrote: > Make musicpal-misc into its own (trivial) qdev device, so we > can get rid of the abuse of sysbus_add_memory(). > > Signed-off-by: Peter Maydell Reviewed-by: Peter Crosthwaite > --- > hw/musicpal.c | 28 +++- >

[Qemu-devel] [PATCH v2 2/5] musicpal: qdevify musicpal-misc

2013-02-25 Thread Peter Maydell
Make musicpal-misc into its own (trivial) qdev device, so we can get rid of the abuse of sysbus_add_memory(). Signed-off-by: Peter Maydell --- hw/musicpal.c | 28 +++- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/hw/musicpal.c b/hw/musicpal.c index 272