[Qemu-devel] [PATCH v2 2/6] geometry: Detect blocksize via ioctls in separate static functions

2014-11-19 Thread Ekaterina Tumanova
Move the IOCTL calls that detect logical blocksize from raw_probe_alignment into separate function (probe_logical_blocksize). Introduce function which detect physical blocksize via IOCTL (probe_physical_blocksize). Both functions will be used in the next patch. Signed-off-by: Ekaterina Tumanova -

Re: [Qemu-devel] [PATCH v2 2/6] geometry: Detect blocksize via ioctls in separate static functions

2014-11-21 Thread Christian Borntraeger
Am 19.11.2014 um 11:17 schrieb Ekaterina Tumanova: > Move the IOCTL calls that detect logical blocksize from raw_probe_alignment > into separate function (probe_logical_blocksize). > Introduce function which detect physical blocksize via IOCTL > (probe_physical_blocksize). > Both functions will be

Re: [Qemu-devel] [PATCH v2 2/6] geometry: Detect blocksize via ioctls in separate static functions

2014-11-25 Thread Stefan Hajnoczi
On Fri, Nov 21, 2014 at 11:17:02AM +0100, Christian Borntraeger wrote: > Am 19.11.2014 um 11:17 schrieb Ekaterina Tumanova: > > Move the IOCTL calls that detect logical blocksize from raw_probe_alignment > > into separate function (probe_logical_blocksize). > > Introduce function which detect physi

Re: [Qemu-devel] [PATCH v2 2/6] geometry: Detect blocksize via ioctls in separate static functions

2014-11-27 Thread Markus Armbruster
Ekaterina Tumanova writes: > Move the IOCTL calls that detect logical blocksize from raw_probe_alignment > into separate function (probe_logical_blocksize). > Introduce function which detect physical blocksize via IOCTL > (probe_physical_blocksize). > Both functions will be used in the next patch

Re: [Qemu-devel] [PATCH v2 2/6] geometry: Detect blocksize via ioctls in separate static functions

2014-11-28 Thread Ekaterina Tumanova
Suggest function comment /** * Return logical block size, or zero if we can't figure it out */ { -BDRVRawState *s = bs->opaque; -char *buf; -unsigned int sector_size; - -/* For /dev/sg devices the alignment is not really used. - With buffered I/O, we

Re: [Qemu-devel] [PATCH v2 2/6] geometry: Detect blocksize via ioctls in separate static functions

2014-11-28 Thread Markus Armbruster
Ekaterina Tumanova writes: >> >> Suggest function comment >> >> /** >> * Return logical block size, or zero if we can't figure it out >> */ >> >>> { >>> -BDRVRawState *s = bs->opaque; >>> -char *buf; >>> -unsigned int sector_size; >>> - >>> -/* For /dev/sg devic

Re: [Qemu-devel] [PATCH v2 2/6] geometry: Detect blocksize via ioctls in separate static functions

2014-11-28 Thread Ekaterina Tumanova
On 11/28/2014 03:52 PM, Markus Armbruster wrote: Ekaterina Tumanova writes: Suggest function comment /** * Return logical block size, or zero if we can't figure it out */ { -BDRVRawState *s = bs->opaque; -char *buf; -unsigned int sector_size; - -/* Fo