Re: [Qemu-devel] [PATCH v2 2/9] qmp: Add dirty-bitmap-add and dirty-bitmap-remove

2014-03-14 Thread Eric Blake
On 03/14/2014 01:18 AM, Fam Zheng wrote: >>> >>> +void qmp_dirty_bitmap_add(const char *device, const char *name, >> Do we want this to work on node-names too ? > > I think having dirty bitmap on device is good enough for now. If there is a > necessity we can add on top. How would anything oth

Re: [Qemu-devel] [PATCH v2 2/9] qmp: Add dirty-bitmap-add and dirty-bitmap-remove

2014-03-14 Thread Fam Zheng
On Thu, 03/13 14:26, Benoît Canet wrote: > The Wednesday 12 Mar 2014 à 14:30:57 (+0800), Fam Zheng wrote : > > The new command pair is added to manage user created dirty bitmap. The > > dirty bitmap's name is mandatory and must be unique for the same device, > > but different devices can have bitma

Re: [Qemu-devel] [PATCH v2 2/9] qmp: Add dirty-bitmap-add and dirty-bitmap-remove

2014-03-13 Thread Benoît Canet
The Wednesday 12 Mar 2014 à 14:30:57 (+0800), Fam Zheng wrote : > The new command pair is added to manage user created dirty bitmap. The > dirty bitmap's name is mandatory and must be unique for the same device, > but different devices can have bitmaps with the same names. > > Signed-off-by: Fam Z

[Qemu-devel] [PATCH v2 2/9] qmp: Add dirty-bitmap-add and dirty-bitmap-remove

2014-03-11 Thread Fam Zheng
The new command pair is added to manage user created dirty bitmap. The dirty bitmap's name is mandatory and must be unique for the same device, but different devices can have bitmaps with the same names. Signed-off-by: Fam Zheng --- blockdev.c | 60 +