Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove

2016-06-27 Thread Daniel P. Berrange
On Sat, Jun 25, 2016 at 01:07:10AM +0300, Michael S. Tsirkin wrote: > On Fri, Jun 24, 2016 at 02:08:52PM +0200, Marc-André Lureau wrote: > > On Thu, Jun 23, 2016 at 7:01 PM, Michael S. Tsirkin wrote: > > >> > Maybe what you want is a need_unlink feature. > > >> > Set it for unix sockets only, that

Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove

2016-06-24 Thread Michael S. Tsirkin
On Fri, Jun 24, 2016 at 02:08:52PM +0200, Marc-André Lureau wrote: > On Thu, Jun 23, 2016 at 7:01 PM, Michael S. Tsirkin wrote: > >> > Maybe what you want is a need_unlink feature. > >> > Set it for unix sockets only, that would make some sense. > >> > >> Oh perhaps what you mean is that if the fd

Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove

2016-06-24 Thread Daniel P. Berrange
On Fri, Jun 24, 2016 at 02:08:52PM +0200, Marc-André Lureau wrote: > On Thu, Jun 23, 2016 at 7:01 PM, Michael S. Tsirkin wrote: > >> > Maybe what you want is a need_unlink feature. > >> > Set it for unix sockets only, that would make some sense. > >> > >> Oh perhaps what you mean is that if the fd

Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove

2016-06-24 Thread Marc-André Lureau
On Thu, Jun 23, 2016 at 7:01 PM, Michael S. Tsirkin wrote: >> > Maybe what you want is a need_unlink feature. >> > Set it for unix sockets only, that would make some sense. >> >> Oh perhaps what you mean is that if the fd was passed, we should cleanup the >> unix socket? Yes, I think we should do

Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove

2016-06-23 Thread Michael S. Tsirkin
On Thu, Jun 23, 2016 at 05:08:03AM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > On Thu, Jun 23, 2016 at 07:41:55AM +0300, Michael S. Tsirkin wrote: > > > On Thu, Jun 16, 2016 at 09:28:52PM +0200, marcandre.lur...@redhat.com > > > wrote: > > > > From: Marc-André Lureau

Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove

2016-06-23 Thread Daniel P. Berrange
On Thu, Jun 16, 2016 at 09:28:52PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > qemu leaves unix socket files behind when removing a listening chardev > or leaving. qemu could clean that up, even if doing so isn't race-free. > > Fixes: > https://bugzilla.redhat.com/sho

Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove

2016-06-23 Thread Marc-André Lureau
Hi - Original Message - > On Thu, Jun 23, 2016 at 07:41:55AM +0300, Michael S. Tsirkin wrote: > > On Thu, Jun 16, 2016 at 09:28:52PM +0200, marcandre.lur...@redhat.com > > wrote: > > > From: Marc-André Lureau > > > > > > qemu leaves unix socket files behind when removing a listening char

Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove

2016-06-22 Thread Michael S. Tsirkin
On Thu, Jun 23, 2016 at 07:41:55AM +0300, Michael S. Tsirkin wrote: > On Thu, Jun 16, 2016 at 09:28:52PM +0200, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > qemu leaves unix socket files behind when removing a listening chardev > > or leaving. qemu could clean that up, e

Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove

2016-06-22 Thread Michael S. Tsirkin
On Thu, Jun 16, 2016 at 09:28:52PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > qemu leaves unix socket files behind when removing a listening chardev > or leaving. qemu could clean that up, even if doing so isn't race-free. > > Fixes: > https://bugzilla.redhat.com/sho

[Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove

2016-06-16 Thread marcandre . lureau
From: Marc-André Lureau qemu leaves unix socket files behind when removing a listening chardev or leaving. qemu could clean that up, even if doing so isn't race-free. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1347077 Signed-off-by: Marc-André Lureau --- include/qemu/sockets.h