Re: [Qemu-devel] [PATCH v2 35/68] target/arm: Convert CPS (privileged)

2019-08-25 Thread Richard Henderson
On 8/25/19 6:10 PM, Richard Henderson wrote: > On 8/25/19 1:43 PM, Peter Maydell wrote: >> I'm still confused, I think. The hint space is >> + NOP 0011 1010 1000 >> (plus the more specific hint insns before that pattern with >> fixed values in the [7:0] bits). >

Re: [Qemu-devel] [PATCH v2 35/68] target/arm: Convert CPS (privileged)

2019-08-25 Thread Richard Henderson
On 8/25/19 1:43 PM, Peter Maydell wrote: > I'm still confused, I think. The hint space is > + NOP 0011 1010 1000 > (plus the more specific hint insns before that pattern with > fixed values in the [7:0] bits). > CPS falls into that space; but you've placed it wi

Re: [Qemu-devel] [PATCH v2 35/68] target/arm: Convert CPS (privileged)

2019-08-25 Thread Peter Maydell
On Sun, 25 Aug 2019 at 18:28, Richard Henderson wrote: > > On 8/25/19 9:20 AM, Peter Maydell wrote: > > On Mon, 19 Aug 2019 at 22:38, Richard Henderson > > wrote: > >> > >> Signed-off-by: Richard Henderson > >> --- > >> target/arm/translate.c | 87 +++- > >>

Re: [Qemu-devel] [PATCH v2 35/68] target/arm: Convert CPS (privileged)

2019-08-25 Thread Richard Henderson
On 8/25/19 10:28 AM, Richard Henderson wrote: >> CPS shouldn't exist at all for M-profile, but the legacy decoder >> got this wrong too, so we should put that on the todo list for >> fixing later (along, maybe, with UNDEFing on some of the >> unpredictable combinations of M/imod/etc for A profile?)

Re: [Qemu-devel] [PATCH v2 35/68] target/arm: Convert CPS (privileged)

2019-08-25 Thread Richard Henderson
On 8/25/19 9:20 AM, Peter Maydell wrote: > On Mon, 19 Aug 2019 at 22:38, Richard Henderson > wrote: >> >> Signed-off-by: Richard Henderson >> --- >> target/arm/translate.c | 87 +++- >> target/arm/a32-uncond.decode | 3 ++ >> target/arm/t32.decode|

Re: [Qemu-devel] [PATCH v2 35/68] target/arm: Convert CPS (privileged)

2019-08-25 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 87 +++- > target/arm/a32-uncond.decode | 3 ++ > target/arm/t32.decode| 3 ++ > 3 files changed, 42 insertions(+), 51 dele

[Qemu-devel] [PATCH v2 35/68] target/arm: Convert CPS (privileged)

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 87 +++- target/arm/a32-uncond.decode | 3 ++ target/arm/t32.decode| 3 ++ 3 files changed, 42 insertions(+), 51 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c