Re: [Qemu-devel] [PATCH v2 4/4] libqos/ahci: Swap memread/write with bufread/write

2015-05-05 Thread John Snow
On 05/05/2015 12:19 PM, Paolo Bonzini wrote: > > > On 05/05/2015 17:48, John Snow wrote: >> I specifically left things that alter control flow using hex nibbles -- >> such as the FIS packets, PRD tables, and all other existing tests. I >> only use the b64 encoding for raw data patterns, which d

Re: [Qemu-devel] [PATCH v2 4/4] libqos/ahci: Swap memread/write with bufread/write

2015-05-05 Thread Paolo Bonzini
On 05/05/2015 17:48, John Snow wrote: > I specifically left things that alter control flow using hex nibbles -- > such as the FIS packets, PRD tables, and all other existing tests. I > only use the b64 encoding for raw data patterns, which don't really need > to be debugged. Either they match or

Re: [Qemu-devel] [PATCH v2 4/4] libqos/ahci: Swap memread/write with bufread/write

2015-05-05 Thread John Snow
On 05/05/2015 06:35 AM, Paolo Bonzini wrote: On 02/05/2015 02:13, John Snow wrote: I wrote a loop to batch the ascii-hex conversion instead of letting printf do it; then ran some more very, very scientific tests: memset alone: real0m10.888s user0m9.303s sys0m9.146s send-batc

Re: [Qemu-devel] [PATCH v2 4/4] libqos/ahci: Swap memread/write with bufread/write

2015-05-05 Thread Paolo Bonzini
On 02/05/2015 02:13, John Snow wrote: >> > > I wrote a loop to batch the ascii-hex conversion instead of letting > printf do it; then ran some more very, very scientific tests: > > memset alone: > real0m10.888s > user0m9.303s > sys0m9.146s > > send-batching: > real0m6.541s > us

Re: [Qemu-devel] [PATCH v2 4/4] libqos/ahci: Swap memread/write with bufread/write

2015-05-01 Thread John Snow
On 05/01/2015 04:48 PM, Paolo Bonzini wrote: On 01/05/2015 21:55, John Snow wrote: Where it makes sense, use the new faster primitives. For generally small reads/writes such as for the PRDT and FIS packets, stick with the more wasteful but easier to debug memread/memwrite. For ahci-test; Wi

Re: [Qemu-devel] [PATCH v2 4/4] libqos/ahci: Swap memread/write with bufread/write

2015-05-01 Thread John Snow
On 05/01/2015 04:48 PM, Paolo Bonzini wrote: On 01/05/2015 21:55, John Snow wrote: Where it makes sense, use the new faster primitives. For generally small reads/writes such as for the PRDT and FIS packets, stick with the more wasteful but easier to debug memread/memwrite. For ahci-test; Wi

Re: [Qemu-devel] [PATCH v2 4/4] libqos/ahci: Swap memread/write with bufread/write

2015-05-01 Thread Paolo Bonzini
On 01/05/2015 21:55, John Snow wrote: > Where it makes sense, use the new faster primitives. > For generally small reads/writes such as for the PRDT > and FIS packets, stick with the more wasteful but > easier to debug memread/memwrite. > > For ahci-test; > With this patch: > real 0m4.802s > us

[Qemu-devel] [PATCH v2 4/4] libqos/ahci: Swap memread/write with bufread/write

2015-05-01 Thread John Snow
Where it makes sense, use the new faster primitives. For generally small reads/writes such as for the PRDT and FIS packets, stick with the more wasteful but easier to debug memread/memwrite. For ahci-test; With this patch: real0m4.802s user0m3.506s sys 0m2.393s Without this series: re