Re: [Qemu-devel] [PATCH v23 09/32] add qemu_opts_append to repalce append_option_parameters

2014-03-25 Thread Eric Blake
On 03/21/2014 04:12 AM, Chunyan Liu wrote: s/repalce/replace/ in subject Also, your overall series could probably use subject lines with a prefix that makes it obvious they are related to a common category; maybe "opts: ". > For later merge .create_opts of drv and proto_drv in qemu-img commands.

Re: [Qemu-devel] [PATCH v23 09/32] add qemu_opts_append to repalce append_option_parameters

2014-03-25 Thread Leandro Dorileo
On Fri, Mar 21, 2014 at 06:12:20PM +0800, Chunyan Liu wrote: > For later merge .create_opts of drv and proto_drv in qemu-img commands. > > Signed-off-by: Chunyan Liu Reviewed-by: Leandro Dorileo > --- > Changes: > * Following Eric's suggestion, qemu_opts_append() will accept a pair of >

[Qemu-devel] [PATCH v23 09/32] add qemu_opts_append to repalce append_option_parameters

2014-03-21 Thread Chunyan Liu
For later merge .create_opts of drv and proto_drv in qemu-img commands. Signed-off-by: Chunyan Liu --- Changes: * Following Eric's suggestion, qemu_opts_append() will accept a pair of parameters (QEMUOptionParameter and QemuOpts), to handle the inconsistency that some driver uses QemuOp