Re: [Qemu-devel] [PATCH v27 8/8] target/avr: Add tests

2019-07-22 Thread Michael Rolnik
got it. On Mon, Jul 22, 2019 at 3:40 PM Peter Maydell wrote: > On Mon, 22 Jul 2019 at 13:33, Michael Rolnik wrote: > > I changed it to info_report. > > raw binaries are totally fine, however if a user supplies a damaged elf > he > > will never know if no warning/info is reported. > > I find a g

Re: [Qemu-devel] [PATCH v27 8/8] target/avr: Add tests

2019-07-22 Thread Peter Maydell
On Mon, 22 Jul 2019 at 13:33, Michael Rolnik wrote: > I changed it to info_report. > raw binaries are totally fine, however if a user supplies a damaged elf he > will never know if no warning/info is reported. I find a good rule of thumb for architecture specific/board specific code is that if ot

Re: [Qemu-devel] [PATCH v27 8/8] target/avr: Add tests

2019-07-22 Thread Michael Rolnik
I changed it to info_report. raw binaries are totally fine, however if a user supplies a damaged elf he will never know if no warning/info is reported. On Mon, Jul 22, 2019 at 12:41 PM Thomas Huth wrote: > Hi Michael, > > On 22/07/2019 11.16, Michael Rolnik wrote: > > Hi Thomas. > > where shoul

Re: [Qemu-devel] [PATCH v27 8/8] target/avr: Add tests

2019-07-22 Thread Thomas Huth
Hi Michael, On 22/07/2019 11.16, Michael Rolnik wrote: > Hi Thomas. > where should I specify this command? In patch 6/8, you introduced the error message: if (bytes_loaded < 0) { error_report( "Unable to load %s as ELF, trying again as raw binary",

Re: [Qemu-devel] [PATCH v27 8/8] target/avr: Add tests

2019-07-22 Thread Michael Rolnik
Hi Thomas. where should I specify this command? On Sun, Jul 21, 2019 at 10:13 AM Thomas Huth wrote: > On 19/07/2019 15.26, Philippe Mathieu-Daudé wrote: > > On 7/19/19 10:26 AM, Michael Rolnik wrote: > [...] > >> diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c > >> index 24852d4

Re: [Qemu-devel] [PATCH v27 8/8] target/avr: Add tests

2019-07-21 Thread Thomas Huth
On 19/07/2019 15.26, Philippe Mathieu-Daudé wrote: > On 7/19/19 10:26 AM, Michael Rolnik wrote: [...] >> diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c >> index 24852d4c7d..73d273b73f 100644 >> --- a/tests/boot-serial-test.c >> +++ b/tests/boot-serial-test.c >> @@ -16,6 +16,17 @@

Re: [Qemu-devel] [PATCH v27 8/8] target/avr: Add tests

2019-07-19 Thread Michael Rolnik
thanks. On Fri, Jul 19, 2019 at 4:26 PM Philippe Mathieu-Daudé wrote: > On 7/19/19 10:26 AM, Michael Rolnik wrote: > > 1. Avocado test > > The test is based on > > > https://github.com/seharris/qemu-avr-tests/tree/master/free-rtos/Demo > > demo which, If working correctly, prints 'ABCDEF

Re: [Qemu-devel] [PATCH v27 8/8] target/avr: Add tests

2019-07-19 Thread Philippe Mathieu-Daudé
On 7/19/19 10:26 AM, Michael Rolnik wrote: > 1. Avocado test > The test is based on > https://github.com/seharris/qemu-avr-tests/tree/master/free-rtos/Demo > demo which, If working correctly, prints 'ABCDEFGHIJKLMNOPQRSTUVWX' out Note, that test also demonstrates the timer and irq are

[Qemu-devel] [PATCH v27 8/8] target/avr: Add tests

2019-07-19 Thread Michael Rolnik
1. Avocado test The test is based on https://github.com/seharris/qemu-avr-tests/tree/master/free-rtos/Demo demo which, If working correctly, prints 'ABCDEFGHIJKLMNOPQRSTUVWX' out 2. Boot serial test Prinit out 'T' through serial port Signed-off-by: Michael Rolnik --- tests/Makef