Re: [Qemu-devel] [PATCH v3] log: Make glib logging go through QEMU

2018-12-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20181213142719.592-1-cferg...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20181213142719.592-1-cferg...@redhat.com Subject: [Qemu-devel] [PATCH v3] log: Make glib

Re: [Qemu-devel] [PATCH v3] log: Make glib logging go through QEMU

2018-12-13 Thread Daniel P . Berrangé
On Thu, Dec 13, 2018 at 03:27:19PM +0100, Christophe Fergeau wrote: > This commit adds a qemu_init_logging() helper which calls > g_log_set_default_handler() so that glib logs (g_log, g_warning, ...) > are handled similarly to other QEMU logs. This means they will get a > timestamp if timestamps

[Qemu-devel] [PATCH v3] log: Make glib logging go through QEMU

2018-12-13 Thread Christophe Fergeau
This commit adds a qemu_init_logging() helper which calls g_log_set_default_handler() so that glib logs (g_log, g_warning, ...) are handled similarly to other QEMU logs. This means they will get a timestamp if timestamps are enabled, and they will go through the monitor if one is configured. This